From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Add xwidget-webkit-isearch-yank-kill Date: Wed, 10 Nov 2021 16:00:01 +0200 Message-ID: <83zgqc2jry.fsf@gnu.org> References: <878rxw71v0.fsf.ref@yahoo.com> <878rxw71v0.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18971"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 10 15:06:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkoEq-0004hu-7x for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Nov 2021 15:06:08 +0100 Original-Received: from localhost ([::1]:44430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkoEp-0004Hs-9J for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Nov 2021 09:06:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mko97-0007C1-SK for emacs-devel@gnu.org; Wed, 10 Nov 2021 09:00:16 -0500 Original-Received: from [2001:470:142:3::e] (port=59740 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mko97-0007g8-If; Wed, 10 Nov 2021 09:00:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OOFiTNOVDtcBiEnsI0HvtxoZQVLRgiOkFliv1DUVUxQ=; b=n4HzCGHsrMyv eD+EWseNWog2dfI07UOlEOp77EsxA3sLu0hCMF8MwBcMC8hr4YhR1+DJBlatnih1vRa1LE7PkcsCY YhYgSQCPdOB9WJSo4mxPmUQJzu/Iig5L/jJTO3SzZb3yLs8Uy/Izh2DF5VjSXv2+9JrXCW3T1CPvh uMlaqpiMi4F16+lmbQPsg+d/04FC2JPZjmOTySTCx7uap7iR55E7IwpqWQK0nuIqQidSHqHEqx3KY emJg/Q1sz/n+B2iAfkSkCD51/PkEOq05eH843IUty06PaWWFOf4edhWCQoE8gez1LYGPx5orURb6/ 0AcAb3xMZgNLL33oWOZY4A==; Original-Received: from [87.69.77.57] (port=4979 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mko91-00055J-0g; Wed, 10 Nov 2021 09:00:09 -0500 In-Reply-To: <878rxw71v0.fsf@yahoo.com> (message from Po Lu on Wed, 10 Nov 2021 18:15:47 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279169 Archived-At: > From: Po Lu > Date: Wed, 10 Nov 2021 18:15:47 +0800 > > I added a command that behaves like `isearch-yank-kill' to xwidget > webkit isearch. > > Does anyone want to make a comment before I push it? Thanks. Thanks, I have a few minor comments: > * lisp/xwidget.el: Bind C-y to xwidget-webkit-yank-kill in incremental This line is too long. We produce ChangeLog from the Git log, where each entry has a TAB before it. So each line in the commit log message should not be longer than 66 characters, because ChangeLog entries wrap at column 74. > +(defun xwidget-webkit-isearch-yank-kill () > + "Pull string from kill ring and append it to the current query." ^^^^^^ Which string? I think you mean the most recent kill, don't you?