From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs pretest 28.0.90 is out Date: Thu, 09 Dec 2021 14:43:05 +0200 Message-ID: <83zgpat0di.fsf@gnu.org> References: <87wnkjpaff.fsf@yahoo.com> <831r2r47lk.fsf@gnu.org> <87sfv7p9uw.fsf@yahoo.com> <83zgpf2mdr.fsf@gnu.org> <87fsr6pn9r.fsf@yahoo.com> <834k7l3nko.fsf@gnu.org> <87o85tlv9o.fsf@yahoo.com> <87a6hdlukl.fsf@yahoo.com> <83pmq925hc.fsf@gnu.org> <87tufljldf.fsf@yahoo.com> <87pmq9jh21.fsf@yahoo.com> <83k0ggzg6v.fsf@gnu.org> <87r1angb8d.fsf@yahoo.com> <838rwvxofc.fsf@gnu.org> <877dcfdy7a.fsf@yahoo.com> <83mtlbw75d.fsf@gnu.org> <8735n2cyui.fsf@yahoo.com> <83k0geuoi1.fsf@gnu.org> <87czm6ax3c.fsf@yahoo.com> <838rwuukkx.fsf@gnu.org> <878rwuavr7.fsf@yahoo.com> <831r2mug6n.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8795"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: luangruo@yahoo.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 09 13:46:21 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvIoX-00024V-5I for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Dec 2021 13:46:21 +0100 Original-Received: from localhost ([::1]:38822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvIoW-0005RV-1P for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Dec 2021 07:46:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44876) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvIlm-0003pW-Ct for emacs-devel@gnu.org; Thu, 09 Dec 2021 07:43:30 -0500 Original-Received: from [2001:470:142:3::e] (port=40394 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvIlm-0000OS-1s; Thu, 09 Dec 2021 07:43:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xvNOo4wO+DVf5dc2/iGNxU2QtitIASl5Y262flqvc4s=; b=nNmwIIaim5DI w4rjcb10HQwZOIsyu1HInX+9obvWF/XBoOZ8VHTC+nwtOMQxf8Ef+e1ouWE8lmeuxWixzyngrD9zZ /7Cmc5pq6NNVXFypuDs37R52UcnuqtlKqQRTA5hJOhfTxic355dlL7vQhiEwJG04e5R2y0fvGw8xf 9z0vNvR5B9WvtkZrejSCYswRA2L50vTMqQFDK+So3kEvHd5oNN2SmbLqu4RYB8AIVREHFeHbQByxr iCpcvoAy9ryDN7TMoi8ZpW+t9RZiBZGq2qsjMOuBX24qPor0SNwXVcFnohiW+t040cP5iqGogQON1 cW+AVCO7r+UZKZavRuDHqg==; Original-Received: from [87.69.77.57] (port=1060 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvIld-0004hr-B9; Thu, 09 Dec 2021 07:43:29 -0500 In-Reply-To: <831r2mug6n.fsf@gnu.org> (message from Eli Zaretskii on Thu, 09 Dec 2021 14:16:16 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281487 Archived-At: > Date: Thu, 09 Dec 2021 14:16:16 +0200 > From: Eli Zaretskii > Cc: emacs-devel@gnu.org > > > After implementing the missing functions, the linker complained about > > duplicate copies of mktime, one in libc.a, and the other in gnulib's > > mktime module > > If we have mktime from Gnulib, then why does linker pull mktime from > libc.a as well? It's supposed to be satisfied by the first function > by that name that it sees in any library it links in. I think I know the answer: it's because we use localtime, which DJGPP defines on the same source file as mktime. I see that in the Emacs 26.2 build, the function mktime in Gnulib's mktime.c module was renamed to rpl_mktime, which is how the duplicate definition problem was resolved. The current Gnulib's mktime.c module still allows that (search mktime.c for "rpl"), so all you need to do is arrange for the relevant cpp macro to be defined. This is supposed to be done by sed2v2.inp, so I guess it is somehow not working now?