From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Making `x-underline-at-descent-line' a face attribute Date: Fri, 07 Jan 2022 09:12:21 +0200 Message-ID: <83zgo858a2.fsf@gnu.org> References: <87lezt5v7h.fsf.ref@yahoo.com> <87lezt5v7h.fsf@yahoo.com> <83r19l8d94.fsf@gnu.org> <87wnjd434b.fsf@yahoo.com> <83ee5l8433.fsf@gnu.org> <877dbd3vdk.fsf@yahoo.com> <8335m17z17.fsf@gnu.org> <87tueg1iei.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24686"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 07 08:16:04 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5jTn-0006GY-4j for ged-emacs-devel@m.gmane-mx.org; Fri, 07 Jan 2022 08:16:03 +0100 Original-Received: from localhost ([::1]:33950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5jTl-00028Q-Kf for ged-emacs-devel@m.gmane-mx.org; Fri, 07 Jan 2022 02:16:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5jPz-0007WM-7Z for emacs-devel@gnu.org; Fri, 07 Jan 2022 02:12:08 -0500 Original-Received: from [2001:470:142:3::e] (port=38396 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5jPy-0001Fj-SI; Fri, 07 Jan 2022 02:12:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=j5yjrNFc/Yw8KzDO8uBnl1RtqDEOYDvXMGiOEadrvpc=; b=Vg2eBEnsL7+g rAhnUKHGZU1ArZm+d1kDcN1vtP0QVjy8T8iSXfsrubCyEUlw8uW0oXxCPQuyeRCcFXERlgAhfZPsH Oeol+9wcHwsxHeiWKLEVWVbCW1sM5MdBiv1OY3+KyPtDmrv4hV2vJeUNiFgWHY0gyqtS5q+F3bMpN UEBmJiP45jI6DsEGkJ0efxXhF2t8hxJiqFTFR7GlG39Lplt3Yd9+mhd7mqi4NiK+BeU+WRCSUCXsZ EfdU+DP4S/FFv9KQxyI4wh24AAOmx0avYKKZsccIcRq/g7v0QluA7dox3Ovebu7rF0HhlKJMR/JFS w3NoajLax2BV3veiWb/hXg==; Original-Received: from [87.69.77.57] (port=4664 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5jPx-0007A3-Lr; Fri, 07 Jan 2022 02:12:06 -0500 In-Reply-To: <87tueg1iei.fsf@yahoo.com> (message from Po Lu on Fri, 07 Jan 2022 08:47:17 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284375 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Fri, 07 Jan 2022 08:47:17 +0800 > > Eli Zaretskii writes: > > > What would you like me to elaborate on? the :extend attribute? or > > something else? > > Yes, specifically the issues encountered while adding it. There were too many, search the debbugs database. Basically, how to merge faces with different values of the attribute, how to inherit the attribute, etc. > > For example, what does it mean when a face specifies this new > > attribute, but doesn't specify :underline? Or what if it does specify > > :underline, but its style is 'wave'? > > If :underline isn't specified but this new attribute is, then the > underline should just not be drawn. As for a wave, it can be drawn at > the descent line as well. Those are your opinions, but they are not necessarily correct/evident, and I can envision use cases and/or users who would have different expectations. It is better to avoid the need to resolve these issues in the first place.