From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: HEAD fails to build with --enable-checking=structs Date: Wed, 23 Nov 2022 18:52:13 +0200 Message-ID: <83zgchy5oi.fsf@gnu.org> References: <1125b2504a1ac9eccf44352a96837b3d96556a6b.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34495"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, casouri@gmail.com To: Vibhav Pant Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 23 17:52:54 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxszV-0008hQ-3p for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Nov 2022 17:52:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxsyu-0003R8-0l; Wed, 23 Nov 2022 11:52:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxsyq-0003Qr-NH for emacs-devel@gnu.org; Wed, 23 Nov 2022 11:52:12 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxsyj-00073x-3A; Wed, 23 Nov 2022 11:52:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=qEJdN077oFgFjZ9/antLvH2SDhwOENLdI3cPzsCcoLg=; b=J3rNs547U7S6RNBnFEmu GmXuRZi+ZIwOSiR4y51B/LJxHTkFtziwce1ezZ/k2r00Gs9J5rQwwouSosAyK7t3bPFc4brpuQVw6 16txHF/7EwqHERALo7/o9I0NKTNpL8ERxRwrBoybfR+sAY0EvffRZuNwxrVljgqIm2rsWo1x7zr6A hhJzQ1P4ACkK/XD7lqEaouvMOqa+8XcyT3Oqz2pFgY7OvpiICX7BvJb3dA+LeLhH5RazZgjV8RNBj 5PHqkLpHMXxuCnkIzyrs5v25GFFXMWrCK1uPusTMBFh0KKzVlB9svDEtYytlrfmpzmKF7X6RMiZef trY3Mypz1+FFzA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxsyb-00044N-1k; Wed, 23 Nov 2022 11:52:04 -0500 In-Reply-To: <1125b2504a1ac9eccf44352a96837b3d96556a6b.camel@gmail.com> (message from Vibhav Pant on Wed, 23 Nov 2022 22:09:56 +0530) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300398 Archived-At: > From: Vibhav Pant > Date: Wed, 23 Nov 2022 22:09:56 +0530 > > HEAD fails to build when configured with "--enable-checking=structs" > with the following error: > > pdumper.c: In function ‘dump_buffer’: > pdumper.c:2752:3: error: #error "buffer changed. See CHECK_STRUCTS > comment in config.h." > 2752 | # error "buffer changed. See CHECK_STRUCTS comment in > config.h." > | ^~~~~ > pdumper.c: In function ‘dump_vectorlike’: > pdumper.c:3004:3: error: #error "pvec_type changed. See > CHECK_STRUCTS comment in config.h." > 3004 | # error "pvec_type changed. See CHECK_STRUCTS comment in > config.h." > | ^~~~~ > > IIUC, this might be due to the tree-sitter changes causing the dmpstruct > hash for the respective types to change. pdumper.c should likely be > updated with the new hashes and placeholder code to abort/error out if a > buffer has associated tree-sitter parsers. Did you read that comment to which this error message alludes? It tells how to fix that, and the key to that is a file that is already there on your system. So if you could post the relevant parts of it, that would help us fix this faster. TIA