HEAD fails to build with --enable-checking=structs

HEAD fails to build with --enable-checking=structs

[Vibhav Pant]

[-- Attachment #1: Type: text/plain, Size: 983 bytes --]

Hi,

HEAD fails to build when configured with "--enable-checking=structs"
with the following error:

   pdumper.c: In function ‘dump_buffer’:
   pdumper.c:2752:3: error: #error "buffer changed. See CHECK_STRUCTS
   comment in config.h."
    2752 | # error "buffer changed. See CHECK_STRUCTS comment in
   config.h."
         |   ^~~~~
   pdumper.c: In function ‘dump_vectorlike’:
   pdumper.c:3004:3: error: #error "pvec_type changed. See
   CHECK_STRUCTS comment in config.h."
    3004 | # error "pvec_type changed. See CHECK_STRUCTS comment in
   config.h."
         |   ^~~~~
   
IIUC, this might be due to the tree-sitter changes causing the dmpstruct
hash for the respective types to change. pdumper.c should likely be
updated with the new hashes and placeholder code to abort/error out if a
buffer has associated tree-sitter parsers.

Thanks,
Vibhav
-- 
Vibhav Pant
vibhavp@gmail.com
GPG: 7ED1 D48C 513C A024 BE3A  785F E3FB 28CB 6AB5 9598

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: HEAD fails to build with --enable-checking=structs

[Eli Zaretskii]

> From: Vibhav Pant <vibhavp@gmail.com>
> Date: Wed, 23 Nov 2022 22:09:56 +0530
> 
> HEAD fails to build when configured with "--enable-checking=structs"
> with the following error:
> 
>    pdumper.c: In function ‘dump_buffer’:
>    pdumper.c:2752:3: error: #error "buffer changed. See CHECK_STRUCTS
>    comment in config.h."
>     2752 | # error "buffer changed. See CHECK_STRUCTS comment in
>    config.h."
>          |   ^~~~~
>    pdumper.c: In function ‘dump_vectorlike’:
>    pdumper.c:3004:3: error: #error "pvec_type changed. See
>    CHECK_STRUCTS comment in config.h."
>     3004 | # error "pvec_type changed. See CHECK_STRUCTS comment in
>    config.h."
>          |   ^~~~~
>    
> IIUC, this might be due to the tree-sitter changes causing the dmpstruct
> hash for the respective types to change. pdumper.c should likely be
> updated with the new hashes and placeholder code to abort/error out if a
> buffer has associated tree-sitter parsers.

Did you read that comment to which this error message alludes?  It tells how
to fix that, and the key to that is a file that is already there on your
system.  So if you could post the relevant parts of it, that would help us
fix this faster.

TIA

Re: HEAD fails to build with --enable-checking=structs

[Eli Zaretskii]

> From: Vibhav Pant <vibhavp@gmail.com>
> Date: Wed, 23 Nov 2022 22:09:56 +0530
> 
>    pdumper.c: In function ‘dump_buffer’:
>    pdumper.c:2752:3: error: #error "buffer changed. See CHECK_STRUCTS
>    comment in config.h."
>     2752 | # error "buffer changed. See CHECK_STRUCTS comment in
>    config.h."
>          |   ^~~~~
>    pdumper.c: In function ‘dump_vectorlike’:
>    pdumper.c:3004:3: error: #error "pvec_type changed. See
>    CHECK_STRUCTS comment in config.h."
>     3004 | # error "pvec_type changed. See CHECK_STRUCTS comment in
>    config.h."
>          |   ^~~~~

I hope I fixed this now.