From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: Changes OK for Emacs 29?
Date: Sat, 21 Jan 2023 10:24:14 +0200 [thread overview]
Message-ID: <83zgacl2hd.fsf@gnu.org> (raw)
In-Reply-To: <875yd07mtf.fsf@yahoo.com> (message from Po Lu on Sat, 21 Jan 2023 08:28:44 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Sat, 21 Jan 2023 08:28:44 +0800
>
> Here are the changes. It's always possible to tell backspace apart from
> delete, and RET from return on Haiku.
>
> diff --git a/lisp/simple.el b/lisp/simple.el
> index 4551b749d56..a38426060e0 100644
> --- a/lisp/simple.el
> +++ b/lisp/simple.el
> @@ -10317,7 +10317,7 @@ normal-erase-is-backspace-setup-frame
> (if (if (eq normal-erase-is-backspace 'maybe)
> (and (not noninteractive)
> (or (memq system-type '(ms-dos windows-nt))
> - (memq window-system '(w32 ns pgtk))
> + (memq window-system '(w32 ns pgtk haiku))
> (and (eq window-system 'x)
> (fboundp 'x-backspace-delete-keys-p)
> (x-backspace-delete-keys-p))
"Always" as in "even on TTY frames"? If so, why haiku is tested only
for GUI frames?
Anyway, this change is fine for the emacs-29 branch. Thanks.
prev parent reply other threads:[~2023-01-21 8:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87cz797cyu.fsf.ref@yahoo.com>
2023-01-20 9:49 ` Changes OK for Emacs 29? Po Lu
2023-01-20 13:28 ` Eli Zaretskii
2023-01-21 0:28 ` Po Lu
2023-01-21 8:24 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zgacl2hd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).