From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Turning c-ts-mode.el, go-ts-mode.el, csharp-ts-mode.el etc into :core packages? Date: Tue, 07 Mar 2023 15:19:20 +0200 Message-ID: <83zg8o66nb.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15374"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 07 14:20:32 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZXF2-0003pd-9r for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Mar 2023 14:20:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZXEG-0007Qt-0f; Tue, 07 Mar 2023 08:19:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZXED-0007NQ-D3 for emacs-devel@gnu.org; Tue, 07 Mar 2023 08:19:41 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZXDz-0001Kf-0q; Tue, 07 Mar 2023 08:19:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=LOOQsLmWm67udN6vySdb4GkCtc6QrLHWJUNqwdqai2Q=; b=fAVpNN6VUJf+rDAGREYw BqSSqKqZGVxh0Oo8mDQYpo0Mnang4w7fD7aJnpN4YVYzSUsI9HjC2UT/9acIYJIHVP9QOrFNAAw3q 5gdUdOYzkA4IP5a+v2KUhQMvNUH0w9GDsLQXg5IVYQ9RgOHC05qu7PAubDVEW4U6x8CgYFMfZOmCF f4Wyvrp+Pweug73LRQFaC24UD8YW78vjYBnXNJejyl8pPXJDX4+/hWkf34cInvDZ0J5aqsRxNZn6U CnFyYBFanFyxF5PFBpsa+GkLACk8rg7MTwdzMd/UoSS+BcbcqwSYeG43I2UyMi+BYl5o8Q3P1nXlW fRBwQOrdLN44+A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZXDx-0003mE-Vp; Tue, 07 Mar 2023 08:19:26 -0500 In-Reply-To: (message from Yuan Fu on Sun, 5 Mar 2023 14:41:17 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304082 Archived-At: > From: Yuan Fu > Date: Sun, 5 Mar 2023 14:41:17 -0800 > > What are the implications of turning something into a :core package? I can’t find much description of it. If my understanding of it is correct, I think it would be beneficial to make new tree-sitter modes into :core packages. Right now they are pretty bare-bones, and haven’t been “battle-tested”. Making them core packages would allow us gradually improve them and fix errors that come up. Those files I mentioned in the subject are new files, if that matters. But I don’t know if there are any downsides of turning something into a :core package. > > The new tree-sitter related files we have are: > - c-ts-mode.el > - java-ts-mode.el > - rust-ts-mode.el > - go-ts-mode.el > - dockerfile-ts-mode.el > - cmake-ts-mode.el > - yaml-ts-mode.el > - typescript-ts-mode.el > - ruby-ts-mode.el > - toml-ts-mode.el > > And we have a few “combined” files: > - python.el (already a :core package) > - js.el > - sh-script.el Isn't :core only relevant for ELPA packages and not for something that is bundled with Emacs?