From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Android port Date: Sun, 06 Aug 2023 13:40:10 +0300 Message-ID: <83zg34pi7p.fsf@gnu.org> References: <1428589171.162865.1691134964773@mail1.libero.it> <3473524.ldcX8TXnAK@nimes> <83fs4xslst.fsf@gnu.org> <6358080.k4LH7P0x6x@nimes> <83edkhskyq.fsf@gnu.org> <87jzu97hu2.fsf@yahoo.com> <835y5tse75.fsf@gnu.org> <83zg35qz7m.fsf@gnu.org> <87cz016oxn.fsf@yahoo.com> <83msz4rcil.fsf@gnu.org> <878rao7o8o.fsf@yahoo.com> <83h6pcrbe9.fsf@gnu.org> <87v8ds5xr4.fsf@yahoo.com> <838raoqzro.fsf@gnu.org> <87r0og5wzt.fsf@yahoo.com> <83350wqzci.fsf@gnu.org> <87msz45wd1.fsf@yahoo.com> <831qggqyln.fsf@gnu.org> <87il9s5vmv.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18703"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eggert@cs.ucla.edu, bruno@clisp.org, angelo.g0@libero.it, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 06 12:40:34 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qSbBa-0004ed-96 for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Aug 2023 12:40:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSbB0-00031w-MS; Sun, 06 Aug 2023 06:39:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSbAx-00031S-QF for emacs-devel@gnu.org; Sun, 06 Aug 2023 06:39:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSbAw-0005He-LK; Sun, 06 Aug 2023 06:39:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qJOo6g2fkpfiY3ayxG5q9PTIjlOL5L9KexM67b6iJsA=; b=Pr1P4uDWrF9T XmCcDAwRLJD/7gUoHUg2/2g1kJfvDOypUNLhP/d7yugm5Ub3kl9x7udQjXUC9eEcnghjGnm185I0l 5hI1f3Rbk96s2aNQZRpL2D853nHpLczFdVsH0qJny45L1lOYecm3GmL2xZq8dG/n+Vl82240jDtJ2 o+6leIgc3xXJnl2ANYBMqiPzuGnhcpjSe2IZWmpo4fUZlc6TGvLZjcjSvBrir1AqMvX0JA8emDyp7 6+2ZBzvmh5IQFbJBXwEqzKr5V73SztXoolfjnqbISFrFBV0/C6Hgd4hgPJaGWW0lhZ2OzRVambpkq RVFIz/8AMB6frTazx7CPiw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSbAw-0004Dr-5A; Sun, 06 Aug 2023 06:39:54 -0400 In-Reply-To: <87il9s5vmv.fsf@yahoo.com> (message from Po Lu on Sun, 06 Aug 2023 18:10:32 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308344 Archived-At: > From: Po Lu > Cc: eggert@cs.ucla.edu, bruno@clisp.org, angelo.g0@libero.it, > emacs-devel@gnu.org > Date: Sun, 06 Aug 2023 18:10:32 +0800 > > Eli Zaretskii writes: > > > Then I don't think I understand this, since (a) MinGW64 which Angelo > > uses does have asprintf, and (b) we could use the configure variable > > that records the existence of asprintf to override that, like we do > > with other ac_cv_func_* variables. But for some reason you didn't use > > that variable (or any similar one) in your proposed patch, why? > > That's because my patch was an addendum to changes installed on the > feature/android branch months ago. The diff between mingw-cfg.site on > the branch and on master is more illustrative: > > diff --git a/nt/mingw-cfg.site b/nt/mingw-cfg.site > index 425eaace30d..f78ee525bf1 100644 > --- a/nt/mingw-cfg.site > +++ b/nt/mingw-cfg.site > @@ -173,3 +173,21 @@ gl_cv_func_nanosleep=yes > # Suppress configure-time diagnostic from unnecessary libxattr check, > # as xattr will not be supported here. > enable_xattr=no > +# Don't build gnulib printf either. > +gl_cv_func_printf_sizes_c99=yes > +gl_cv_func_printf_sizes_c23=yes > +gl_cv_func_printf_long_double=yes > +gl_cv_func_printf_infinite_long_double=yes > +gl_cv_func_printf_directive_a=yes > +gl_cv_func_printf_directive_b=yes > +gl_cv_func_printf_directive_f=yes > +gl_cv_func_printf_directive_n=yes > +gl_cv_func_printf_directive_ls=yes > +gl_cv_func_printf_directive_lc=yes > +gl_cv_func_printf_positions=yes > +gl_cv_func_printf_flag_grouping=yes > +gl_cv_func_printf_flag_leftadjust=yes > +gl_cv_func_printf_flag_zero=yes > +gl_cv_func_printf_precision=yes > +gl_cv_func_printf_enomem=yes > +ac_cv_func_vasprintf=yes Isn't there some "summary" variable for printf, like gl_cv_func_printf_works or some such, which is set if all of the above variables are set? I'd prefer to override summary if it exists, rather than each one of the above function-testing variables individually. > Both the check for vasprintf (Gnulib eschews testing for asprintf, since > asprintf is never present where vasprintf is not) and the checks for > printf features are overridden, because Gnulib also tries to replace > vasprintf if it discovers that the conventional printf functions will > need to be replaced. Perhaps we should ask Gnulib to allow disabling these in a more convenient manner.