unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Changes in dos-fns.el
Date: Fri, 14 May 2010 20:26:24 +0300	[thread overview]
Message-ID: <83y6fm2y4f.fsf@gnu.org> (raw)


  2010-05-13  Stefan Monnier  <monnier@iro.umontreal.ca>

	  * dos-fns.el: Add "dos-" prefix for namespace control.
	  (convert-standard-filename): Define as alias for
	  dos-convert-standard-filename but only if applicable.

The more I think about these changes, the less I like them.

These functions are very old, some from 1996, others from 1994, and in
all that time no one complained about them.  What kind of use-case was
important enough to change their names now in an incompatible fashion?

Yes, I've read the comments about convert-standard-filename.  Again,
no one complained about what happens when someone loads dos-fns on
other platforms.  Why is this suddenly an issue now?  And if its _is_
an issue, why it gets fixed only in dos-fns, not in other places where
we have overriding definitions for this function?  In any case, I
could think of better ways of fixing this.  For example, we could lump
all the definitions in the body of a single function on file.el, each
alternative conditioned by the underlying OS.

But if I could somehow understand the motivation for the change of
convert-standard-filename, I have no idea what are the advantages of
renaming venerable functions such as intdos and mode4350.  Can they
really cause name clashes?  And if they can, how come that didn't
happen even once in the last 15 years?  Besides, mode25 and mode4350
are documented in the manual, and I expect them to be fairly popular
amongst DOS users (when I was one, I had a call to mode4350 in my
.emacs).  Why change the name now without leaving behind a defalias?

Unless I miss some very important aspects of this, I really, REALLY
think we should revert these changes.



             reply	other threads:[~2010-05-14 17:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-14 17:26 Eli Zaretskii [this message]
2010-05-14 19:39 ` Changes in dos-fns.el Stefan Monnier
2010-05-14 20:50   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y6fm2y4f.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).