From: Eli Zaretskii <eliz@gnu.org>
To: Ken Brown <kbrown@cornell.edu>
Cc: dann@gnu.org, emacs-devel@gnu.org
Subject: Re: EMACS_GET_TTY_PGRP vs. emacs_get_tty_pgrp
Date: Wed, 20 Oct 2010 22:21:12 +0200 [thread overview]
Message-ID: <83y69s8vk7.fsf@gnu.org> (raw)
In-Reply-To: <4CBF4AA6.3000200@cornell.edu>
> Date: Wed, 20 Oct 2010 16:01:42 -0400
> From: Ken Brown <kbrown@cornell.edu>
> Cc: emacs-devel <emacs-devel@gnu.org>
>
> But then I still think emacs_get_tty_pgrp in process.c should be changed
> so that it works on systems that have tcgetpgrp but not TIOCGPGRP. How
> would you recommend handling this? Is it necessary to use conditional
> code as in the emacs-23 definition of EMACS_GET_TTY_PGRP, or is it safe
> to just always use tcgetpgrp as in the trunk's version of
> EMACS_GET_TTY_PGRP?
I would suggest to use TIOCGPGRP (inside emacs_get_tty_pgrp) if it's
available, because at least on some systems it allows to access file
descriptors of processes other than the current one, while tcgetpgrp
does not.
Please note that emacs_get_tty_pgrp is used elsewhere in process.c,
and also make sure that it does what it does today on systems (w32)
which have neither TIOCGPGRP nor tcgetpgrp.
next prev parent reply other threads:[~2010-10-20 20:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 14:22 EMACS_GET_TTY_PGRP vs. emacs_get_tty_pgrp Ken Brown
2010-10-20 15:14 ` Andreas Schwab
2010-10-20 18:39 ` Ken Brown
2010-10-20 18:59 ` Dan Nicolaescu
2010-10-20 20:01 ` Ken Brown
2010-10-20 20:21 ` Eli Zaretskii [this message]
2010-10-20 20:28 ` Dan Nicolaescu
2010-10-20 21:28 ` Ken Brown
2010-10-20 21:36 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y69s8vk7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dann@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).