From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Truncating scroll runs that copy to where we copied to Date: Sat, 26 Nov 2011 14:44:02 +0200 Message-ID: <83y5v36okt.fsf@gnu.org> References: <8339dibqlc.fsf@gnu.org> <6D358885-0CD8-4FC0-9598-549AB7E3D4AC@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1322311484 7563 80.91.229.12 (26 Nov 2011 12:44:44 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 26 Nov 2011 12:44:44 +0000 (UTC) Cc: david.reitter@gmail.com, emacs-devel@gnu.org To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 26 13:44:40 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RUHcV-0005ea-Re for ged-emacs-devel@m.gmane.org; Sat, 26 Nov 2011 13:44:40 +0100 Original-Received: from localhost ([::1]:52030 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RUHcV-0006NT-4s for ged-emacs-devel@m.gmane.org; Sat, 26 Nov 2011 07:44:39 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:58199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RUHcR-0006NO-9I for emacs-devel@gnu.org; Sat, 26 Nov 2011 07:44:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RUHcQ-0000CJ-5P for emacs-devel@gnu.org; Sat, 26 Nov 2011 07:44:35 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:60200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RUHcP-0000C7-Rx for emacs-devel@gnu.org; Sat, 26 Nov 2011 07:44:34 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LV900000PVSLY00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Sat, 26 Nov 2011 14:43:59 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.229.100.85]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LV900MLKQ1A5WC0@a-mtaout20.012.net.il>; Sat, 26 Nov 2011 14:43:59 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:146252 Archived-At: > Date: Wed, 23 Nov 2011 09:41:18 +0900 > From: YAMAMOTO Mitsuharu > Cc: david.reitter@gmail.com, > emacs-devel@gnu.org > > >>>>> On Tue, 22 Nov 2011 04:54:28 -0500, Eli Zaretskii said: > > > If truncation indirectly prevents copying of disabled rows, then I > > think at least a comment to that effect should be in the loop which > > "assigns the rows". Just looking at the loop, it is not at all > > apparent that only enabled rows are being assigned. > > Maybe we can add an assertion as well as such a comment. Yes, let's do that. > > The question was whether the current code is right when it > > unconditionally sets that flag. If the `from' row is disabled, why > > should its assignee `to' row be enabled? If, after your changes, a > > disabled row is never assigned, then `to' will already have its > > enabled_p flag set, by virtue of the assignment. Either way, > > setting this flag unconditionally after the call to assign_row looks > > bogus to me. (By contrast, resetting the flag in `from' looks like > > TRT, at least as long as we garble it.) > > Ah, I misunderstood that you were proposing setting to->enabled_p to 1 > unconditionally. Yes, maybe we can replace this assignment with an > assertion. Let's do that as well. Otherwise, I think your changes are fine, thanks. At least I cannot find anything wrong with them. Please go ahead and install them.