From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Changes in update-game-score.c Date: Thu, 23 Jan 2014 18:07:16 +0200 Message-ID: <83y526el6z.fsf@gnu.org> References: <8361pbg5vy.fsf@gnu.org> <52E08D31.3080801@cs.ucla.edu> <8338kffj7m.fsf@gnu.org> <52E0A0ED.4020601@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1390493231 8535 80.91.229.3 (23 Jan 2014 16:07:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 23 Jan 2014 16:07:11 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 23 17:07:18 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W6MoF-0006M3-AH for ged-emacs-devel@m.gmane.org; Thu, 23 Jan 2014 17:07:15 +0100 Original-Received: from localhost ([::1]:41983 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6MoE-0004ZU-KC for ged-emacs-devel@m.gmane.org; Thu, 23 Jan 2014 11:07:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6Mo6-0004Yc-KT for emacs-devel@gnu.org; Thu, 23 Jan 2014 11:07:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6Mo1-00042r-8E for emacs-devel@gnu.org; Thu, 23 Jan 2014 11:07:06 -0500 Original-Received: from mtaout29.012.net.il ([80.179.55.185]:59210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6Mo1-000423-0p for emacs-devel@gnu.org; Thu, 23 Jan 2014 11:07:01 -0500 Original-Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0MZV00M003D8MG00@mtaout29.012.net.il> for emacs-devel@gnu.org; Thu, 23 Jan 2014 18:08:15 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MZV00CMN3HR3XA0@mtaout29.012.net.il>; Thu, 23 Jan 2014 18:08:15 +0200 (IST) In-reply-to: <52E0A0ED.4020601@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.185 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168958 Archived-At: > Date: Wed, 22 Jan 2014 20:56:13 -0800 > From: Paul Eggert > CC: emacs-devel@gnu.org > > Eli Zaretskii wrote: > > The bugfix should have fixed the bug that was reported, and that's it. > > I could have filed a half-dozen bug reports, one for each bug I fixed, > and then installed patches one by one, marking each bug fixed as I did > so. That is exactly what we all should do: each commit is one coherent changeset, solving a problem that is independent of others. I'm sure I'm not saying anything you didn't know. > But that would have been overkill in this case; it would have been > too much work for everybody (particularly for me :-) for too little benefit. Sorry, I disagree. > The bugs included undefined behavior the very nature of which could be > changed by the original fix for the reported bug, and we are talking > setuid here, so here was sufficient justification for fixing them. Now > that they're fixed we can move on. Sorry, cannot move on, not yet. Please at least document the reasons for each part of that commit, as some of them remain unexplained in the logs. And since they are anything but self-explanatory, I don't see how anyone else could do that, or guess. Thanks.