From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: commit-msg hook Date: Fri, 10 Apr 2015 13:43:23 +0300 Message-ID: <83y4m0tgac.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1428662629 16676 80.91.229.3 (10 Apr 2015 10:43:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 10 Apr 2015 10:43:49 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 10 12:43:37 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YgWPO-0007mh-6W for ged-emacs-devel@m.gmane.org; Fri, 10 Apr 2015 12:43:34 +0200 Original-Received: from localhost ([::1]:38506 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgWPN-0007TL-Dl for ged-emacs-devel@m.gmane.org; Fri, 10 Apr 2015 06:43:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgWPK-0007Sz-5p for emacs-devel@gnu.org; Fri, 10 Apr 2015 06:43:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgWPF-0006cd-3J for emacs-devel@gnu.org; Fri, 10 Apr 2015 06:43:30 -0400 Original-Received: from mtaout26.012.net.il ([80.179.55.182]:50411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgWPE-0006cM-RO for emacs-devel@gnu.org; Fri, 10 Apr 2015 06:43:25 -0400 Original-Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0NML00D0074KO400@mtaout26.012.net.il> for emacs-devel@gnu.org; Fri, 10 Apr 2015 13:44:42 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NML00ATX76IPQ20@mtaout26.012.net.il>; Fri, 10 Apr 2015 13:44:42 +0300 (IDT) X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185253 Archived-At: On MS-Windows, this hook fails commits with valid UTF-8 characters in the log messages, probably because the version of Gawk I have here is too old (3.0.4; that's what MSYS comes with). The mawk 1.3.3 replacement regexp for non_print does work, so I suggest to have a Gawk version check in the script, and use the replacement for older Gawk's. Btw, when the hook is run by Git, the "; see 'CONTRIBUTE'" part of the message is not shown; could it be that the semi-colon gets interpreted by the shell, or something like that? (My Git version is 1.9.5.) I would also suggest to say explicitly in the message that the commit was aborted, because it is not at all clear, at least to the uninitiated. It wasn't until I did a "git show" that the fact the commit was aborted became apparent to me. Thanks.