From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: support for true-color terminals Date: Fri, 11 Mar 2016 10:26:07 +0200 Message-ID: <83y49pju8w.fsf@gnu.org> References: <1457660934.533185.545912986.04028913@webmail.messagingengine.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1457684795 10075 80.91.229.3 (11 Mar 2016 08:26:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Mar 2016 08:26:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: Charles Strahan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 11 09:26:27 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aeIOw-0000jz-PV for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2016 09:26:26 +0100 Original-Received: from localhost ([::1]:53355 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeIOq-0004Wa-P2 for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2016 03:26:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeIOm-0004WU-To for emacs-devel@gnu.org; Fri, 11 Mar 2016 03:26:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeIOj-0005NV-JI for emacs-devel@gnu.org; Fri, 11 Mar 2016 03:26:16 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeIOj-0005NH-Fe; Fri, 11 Mar 2016 03:26:13 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3176 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aeIOi-0000jN-H7; Fri, 11 Mar 2016 03:26:12 -0500 In-reply-to: <1457660934.533185.545912986.04028913@webmail.messagingengine.com> (message from Charles Strahan on Thu, 10 Mar 2016 20:48:54 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201449 Archived-At: > From: Charles Strahan > Date: Thu, 10 Mar 2016 20:48:54 -0500 > > A while back, there was an effort to add support for true-color > terminals (by which I mean terminals supporting 16777216 simultaneous > colors): > > http://emacs.1067599.n5.nabble.com/RFC-Add-tty-True-Color-support-td299962.html > > I've contacted Rüdiger, asking if he wouldn't mind if I pick up from > where he left off, and he said that was fine as he's been too busy to > work on this. > > I've attached to this email the patch that I'm using, based on his work. > Any feedback would be greatly appreciated. > > This is my first (attempted) contribution to Emacs, and I'm very new to > the code base, so there might be some silly mistakes that I'm unaware > of. If we can get this polished enough for inclusion, I'd be more than > happy to assign copyright. Thanks. First, I suggest that you start the legal paperwork rolling right now, because without that, discussing such a non-trivial change would be rather pointless. If you agree, I will send you the form off-list. As for the patch: my first comment is about the changes in tty_look_up_color and in map_tty_color -- why are these needed? The sheer number of the supported colors doesn't necessarily require any changes in the basic design of TTY color support, so I'm not sure what was the motivation for these changes. Also, why do we need the 'true-color' option introduced in tty-colors.el? why isn't 'auto' enough for supporting this terminal?