unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Charles Strahan <charles@cstrahan.com>
Cc: emacs-devel@gnu.org
Subject: Re: support for true-color terminals
Date: Fri, 11 Mar 2016 10:26:07 +0200	[thread overview]
Message-ID: <83y49pju8w.fsf@gnu.org> (raw)
In-Reply-To: <1457660934.533185.545912986.04028913@webmail.messagingengine.com> (message from Charles Strahan on Thu, 10 Mar 2016 20:48:54 -0500)

> From: Charles Strahan <charles@cstrahan.com>
> Date: Thu, 10 Mar 2016 20:48:54 -0500
> 
> A while back, there was an effort to add support for true-color
> terminals (by which I mean terminals supporting 16777216 simultaneous
> colors):
> 
> http://emacs.1067599.n5.nabble.com/RFC-Add-tty-True-Color-support-td299962.html
> 
> I've contacted Rüdiger, asking if he wouldn't mind if I pick up from
> where he left off, and he said that was fine as he's been too busy to
> work on this.
> 
> I've attached to this email the patch that I'm using, based on his work.
> Any feedback would be greatly appreciated.
> 
> This is my first (attempted) contribution to Emacs, and I'm very new to
> the code base, so there might be some silly mistakes that I'm unaware
> of. If we can get this polished enough for inclusion, I'd be more than
> happy to assign copyright.

Thanks.

First, I suggest that you start the legal paperwork rolling right now,
because without that, discussing such a non-trivial change would be
rather pointless.  If you agree, I will send you the form off-list.

As for the patch: my first comment is about the changes in
tty_look_up_color and in map_tty_color -- why are these needed?  The
sheer number of the supported colors doesn't necessarily require any
changes in the basic design of TTY color support, so I'm not sure what
was the motivation for these changes.

Also, why do we need the 'true-color' option introduced in
tty-colors.el? why isn't 'auto' enough for supporting this terminal?



  reply	other threads:[~2016-03-11  8:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11  1:48 support for true-color terminals Charles Strahan
2016-03-11  8:26 ` Eli Zaretskii [this message]
2016-03-18  8:05   ` Charles Strahan
2016-04-11  2:16     ` Charles Strahan
2016-04-11  2:37       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y49pju8w.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=charles@cstrahan.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).