From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] ash, lsh: Avoid code duplication Date: Tue, 22 Nov 2016 18:12:08 +0200 Message-ID: <83y40b7auf.fsf@gnu.org> References: <87inrg99in.fsf@gmail.com> <83k2bw9673.fsf@gnu.org> <87d1ho953w.fsf@gmail.com> <83bmx892lx.fsf@gnu.org> <87k2bwp8az.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1479831216 22981 195.159.176.226 (22 Nov 2016 16:13:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 22 Nov 2016 16:13:36 +0000 (UTC) Cc: emacs-devel@gnu.org To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 22 17:13:28 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9DhI-0004VV-9e for ged-emacs-devel@m.gmane.org; Tue, 22 Nov 2016 17:13:28 +0100 Original-Received: from localhost ([::1]:56410 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9DhL-0008W9-Ji for ged-emacs-devel@m.gmane.org; Tue, 22 Nov 2016 11:13:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9Dg9-0008UQ-Kd for emacs-devel@gnu.org; Tue, 22 Nov 2016 11:12:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9Dg4-00020E-MK for emacs-devel@gnu.org; Tue, 22 Nov 2016 11:12:17 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9Dg4-000200-JH; Tue, 22 Nov 2016 11:12:12 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4984 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c9Dg3-0001pR-Tw; Tue, 22 Nov 2016 11:12:12 -0500 In-reply-to: <87k2bwp8az.fsf@gmail.com> (message from Tino Calancha on Tue, 22 Nov 2016 11:17:24 +0900) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209546 Archived-At: > From: Tino Calancha > CC: emacs-devel@gnu.org, Tino Calancha > Date: Tue, 22 Nov 2016 11:17:24 +0900 > > Eli Zaretskii writes: > > >> +Lisp_Object > >> +ash_lsh_impl (register Lisp_Object value, Lisp_Object count, bool lsh) > > > > static Lisp_Object > > ash_lsh_impl (register Lisp_Object value, Lisp_Object count, bool lsh) > > > >> diff --git a/src/lisp.h b/src/lisp.h > >> index e087828..c48c2c8 100644 > >> --- a/src/lisp.h > >> +++ b/src/lisp.h > >> @@ -602,6 +602,7 @@ extern void char_table_set (Lisp_Object, int, Lisp_Object); > >> /* Defined in data.c. */ > >> extern _Noreturn Lisp_Object wrong_type_argument (Lisp_Object, Lisp_Object); > >> extern _Noreturn void wrong_choice (Lisp_Object, Lisp_Object); > >> +Lisp_Object ash_lsh_impl (Lisp_Object, Lisp_Object, bool); > > > > No need to declare it here, as it is a static function used only in > > the file in which it is defined. > > Thank you very much. > Here is the updated patch: Thanks, this LGTM. Please push to master if no further comments are posted.