From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: [Emacs-diffs] master fd8f724: * src/xdisp.c (overlay_arrows_changed_p): Fix last change. Date: Tue, 28 Feb 2017 18:10:02 +0200 Message-ID: <83y3wqnvol.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1488298869 18514 195.159.176.226 (28 Feb 2017 16:21:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Feb 2017 16:21:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 28 17:21:00 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cikWB-0003If-M6 for ged-emacs-devel@m.gmane.org; Tue, 28 Feb 2017 17:20:51 +0100 Original-Received: from localhost ([::1]:35207 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cikWH-000866-Ib for ged-emacs-devel@m.gmane.org; Tue, 28 Feb 2017 11:20:57 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cikMD-00080r-9J for emacs-devel@gnu.org; Tue, 28 Feb 2017 11:10:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cikM8-0008EF-BC for emacs-devel@gnu.org; Tue, 28 Feb 2017 11:10:33 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49516) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cikM8-0008E9-7W; Tue, 28 Feb 2017 11:10:28 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3431 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cikM7-0007jh-GU; Tue, 28 Feb 2017 11:10:27 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212650 Archived-At: Stefan, I don't understand the new semantics of overlay_arrows_changed_p, and even less so after your latest updates. The commentary which documents that function's contract is now incorrect, but I don't know how to fix it, because the return value changes based on conditions that make no sense to the caller. I'd prefer to change the function to return true if overlay arrows or overlay arrow string have changed, regardless of whether the argument to the function is true or false and regardless of whether it sets the buffer's redisplay flag. Then the previous contract will still be correct, with just an addition of a side effect when the argument is true. Any reasons not to do that?