From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: [Emacs-diffs] master fd8f724: * src/xdisp.c (overlay_arrows_changed_p): Fix last change.
Date: Tue, 28 Feb 2017 18:10:02 +0200 [thread overview]
Message-ID: <83y3wqnvol.fsf@gnu.org> (raw)
Stefan, I don't understand the new semantics of
overlay_arrows_changed_p, and even less so after your latest updates.
The commentary which documents that function's contract is now
incorrect, but I don't know how to fix it, because the return value
changes based on conditions that make no sense to the caller.
I'd prefer to change the function to return true if overlay arrows or
overlay arrow string have changed, regardless of whether the argument
to the function is true or false and regardless of whether it sets the
buffer's redisplay flag. Then the previous contract will still be
correct, with just an addition of a side effect when the argument is
true. Any reasons not to do that?
next reply other threads:[~2017-02-28 16:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 16:10 Eli Zaretskii [this message]
2017-02-28 17:47 ` [Emacs-diffs] master fd8f724: * src/xdisp.c (overlay_arrows_changed_p): Fix last change Stefan Monnier
2017-02-28 18:09 ` Eli Zaretskii
2017-02-28 18:58 ` Stefan Monnier
2017-02-28 19:11 ` Eli Zaretskii
2017-02-28 20:02 ` Stefan Monnier
2017-03-01 17:03 ` Eli Zaretskii
2017-03-02 5:27 ` Stefan Monnier
2017-03-02 16:02 ` Eli Zaretskii
2017-03-02 18:29 ` Stefan Monnier
2017-03-02 20:18 ` Eli Zaretskii
2017-03-02 22:32 ` Stefan Monnier
2017-03-03 8:11 ` Eli Zaretskii
2017-03-06 2:53 ` Stefan Monnier
2017-03-03 8:13 ` Eli Zaretskii
2017-03-06 4:17 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y3wqnvol.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).