From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Native display of line numbers Date: Sun, 18 Jun 2017 17:40:28 +0300 Message-ID: <83y3spxstf.fsf@gnu.org> References: <83lgoqzm0v.fsf@gnu.org> <83injuzf4e.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1497796868 1474 195.159.176.226 (18 Jun 2017 14:41:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 18 Jun 2017 14:41:08 +0000 (UTC) Cc: emacs-devel@gnu.org To: Kaushal Modi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 18 16:40:59 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMbNr-0008F8-7F for ged-emacs-devel@m.gmane.org; Sun, 18 Jun 2017 16:40:59 +0200 Original-Received: from localhost ([::1]:38576 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMbNt-0006Ot-26 for ged-emacs-devel@m.gmane.org; Sun, 18 Jun 2017 10:41:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMbNf-0006O8-UJ for emacs-devel@gnu.org; Sun, 18 Jun 2017 10:40:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMbNb-0004Rb-1s for emacs-devel@gnu.org; Sun, 18 Jun 2017 10:40:47 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMbNa-0004RN-Td; Sun, 18 Jun 2017 10:40:42 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3288 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dMbNa-0005eC-9W; Sun, 18 Jun 2017 10:40:42 -0400 In-reply-to: (message from Kaushal Modi on Sun, 18 Jun 2017 04:27:38 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215744 Archived-At: > From: Kaushal Modi > Date: Sun, 18 Jun 2017 04:27:38 +0000 > Cc: emacs-devel@gnu.org > > The menu bar is for simple uses, I see no reason to put all the > complexity of a defcustom on the menu bar. > > The toggle-display-line-numbers is an interactive function though. So someone can unknowingly bind it to a > key to toggle line numbers and get confused why their setting to show relative line numbers is getting lost. It > also needs a doc-string saying that that function is only for use from the menu bar, and point the user to look > at display-line-numbers var instead to do what they want. Also if that function is intended to be called only from > the menu bar, should it be prefixed with "menu-bar-"? It would go against the convention used in that file, but it > adds clarity. I think I'll leave it to someone else to improve the interactive customization facilities, once the feature lands on master. I'm not really good with that stuff, so I think I will provide the infrastructure and the initial customization capabilities, and let others pick up where I left off. Thanks again for the feedback.