From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: dired-tests.el fails on MS-Windows Date: Fri, 04 Aug 2017 16:18:26 +0300 Message-ID: <83y3qzwjx9.fsf@gnu.org> References: <83zibjz519.fsf@gnu.org> <87d18fw79z.fsf@calancha-pc> <83pocfyurp.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1501855841 2913 195.159.176.226 (4 Aug 2017 14:10:41 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 4 Aug 2017 14:10:41 +0000 (UTC) Cc: fabrice.popineau@gmail.com, emacs-devel@gnu.org To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 04 16:10:38 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dddJ9-0000ES-M9 for ged-emacs-devel@m.gmane.org; Fri, 04 Aug 2017 16:10:31 +0200 Original-Received: from localhost ([::1]:54119 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dddJF-0002VW-Ma for ged-emacs-devel@m.gmane.org; Fri, 04 Aug 2017 10:10:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddcWs-000886-NC for emacs-devel@gnu.org; Fri, 04 Aug 2017 09:22:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddcV1-00004v-It for emacs-devel@gnu.org; Fri, 04 Aug 2017 09:20:38 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddcV1-0008W6-CK; Fri, 04 Aug 2017 09:18:43 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4518 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ddcUz-0003Ft-AU; Fri, 04 Aug 2017 09:18:43 -0400 In-reply-to: (message from Tino Calancha on Wed, 2 Aug 2017 15:44:59 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217286 Archived-At: > From: Tino Calancha > Date: Wed, 2 Aug 2017 15:44:59 +0900 (JST) > cc: Eli Zaretskii , Tino Calancha , > Emacs developers > > > 2017-08-01 21:04 GMT+02:00 Eli Zaretskii : > > > > Only if there's no better way.  The Patch invocation definitely needs > > the --binary switch on Windows, though.  But the failure above is not > > about that, it's about something else, because directory-files returns > > an empty list.  Something prevents Patch from creating backup files. > > > > > > When I add the '--binary' option to patch, the test passes. > > Again, windows 10, mingw64. > Fabrice, Eli > does the following work in your environments? Yes, it passes now. Thanks!