From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs release branch warnings with GCC 8 Date: Mon, 30 Apr 2018 22:38:38 +0300 Message-ID: <83y3h4qybl.fsf@gnu.org> References: <0d193e2f-bb41-ade7-fc31-5f353044f8cb@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1525117017 19379 195.159.176.226 (30 Apr 2018 19:36:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 30 Apr 2018 19:36:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 30 21:36:53 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDEbU-0004ub-O6 for ged-emacs-devel@m.gmane.org; Mon, 30 Apr 2018 21:36:52 +0200 Original-Received: from localhost ([::1]:33063 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDEdZ-0002j6-OO for ged-emacs-devel@m.gmane.org; Mon, 30 Apr 2018 15:39:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDEdT-0002ix-66 for emacs-devel@gnu.org; Mon, 30 Apr 2018 15:38:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDEdO-0006v3-Ap for emacs-devel@gnu.org; Mon, 30 Apr 2018 15:38:55 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDEdO-0006uz-70; Mon, 30 Apr 2018 15:38:50 -0400 Original-Received: from [176.228.60.248] (port=1858 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fDEdN-0002mw-J5; Mon, 30 Apr 2018 15:38:50 -0400 In-reply-to: <0d193e2f-bb41-ade7-fc31-5f353044f8cb@cs.ucla.edu> (message from Paul Eggert on Mon, 30 Apr 2018 10:12:36 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224996 Archived-At: > From: Paul Eggert > Date: Mon, 30 Apr 2018 10:12:36 -0700 > > The emacs-26 branch has some warnings when compiled on Fedora 28, which > is scheduled for release next week; see attached. This is because Fedora > 28 uses GCC 8.0.1, and when --enable-gcc-warnings is used (which is the > default in a build from Git), GCC 8 issues some warnings that GCC 7 does > not. But a release tarball is not built with --enable-gcc-warnings by default, right? > I've patched the master to fix this problem in commits > 2b9ab8c8fba849da8bf2aa45e65b122bb937a6b3 and > 8c3215e7a47e3caaa005bf573765ed63e0739b89, and could backport these > patches (or a subset) to emacs-26 if there's interest. I'm okay with the first one, but I don't understand how the warnings you've shown are related to the ATTRIBUTE_MALLOC changes in the second commit. If those are not necessary to shut up warnings, I'd prefer not to backport those, as the attribute stuff can be a potential portability problem. Thanks.