unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: Emacs release branch warnings with GCC 8
Date: Mon, 30 Apr 2018 22:38:38 +0300	[thread overview]
Message-ID: <83y3h4qybl.fsf@gnu.org> (raw)
In-Reply-To: <0d193e2f-bb41-ade7-fc31-5f353044f8cb@cs.ucla.edu> (message from Paul Eggert on Mon, 30 Apr 2018 10:12:36 -0700)

> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Mon, 30 Apr 2018 10:12:36 -0700
> 
> The emacs-26 branch has some warnings when compiled on Fedora 28, which 
> is scheduled for release next week; see attached. This is because Fedora 
> 28 uses GCC 8.0.1, and when --enable-gcc-warnings is used (which is the 
> default in a build from Git), GCC 8 issues some warnings that GCC 7 does 
> not.

But a release tarball is not built with --enable-gcc-warnings by
default, right?

> I've patched the master to fix this problem in commits 
> 2b9ab8c8fba849da8bf2aa45e65b122bb937a6b3 and 
> 8c3215e7a47e3caaa005bf573765ed63e0739b89, and could backport these 
> patches (or a subset) to emacs-26 if there's interest.

I'm okay with the first one, but I don't understand how the warnings
you've shown are related to the ATTRIBUTE_MALLOC changes in the second
commit.  If those are not necessary to shut up warnings, I'd prefer
not to backport those, as the attribute stuff can be a potential
portability problem.

Thanks.



  reply	other threads:[~2018-04-30 19:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 17:12 Emacs release branch warnings with GCC 8 Paul Eggert
2018-04-30 19:38 ` Eli Zaretskii [this message]
2018-04-30 19:52   ` Paul Eggert
2018-04-30 19:58     ` Eli Zaretskii
2018-05-01  0:22       ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y3h4qybl.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).