From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Thoughts on getting correct line numbers in the byte compiler's warning messages Date: Mon, 05 Nov 2018 17:57:35 +0200 Message-ID: <83y3a7cya8.fsf@gnu.org> References: <20181101175953.GC4504@ACM> <20181105105302.GA10520@ACM> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1541433984 26039 195.159.176.226 (5 Nov 2018 16:06:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 5 Nov 2018 16:06:24 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 05 17:06:20 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJhOM-0006ab-Q4 for ged-emacs-devel@m.gmane.org; Mon, 05 Nov 2018 17:06:18 +0100 Original-Received: from localhost ([::1]:35984 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJhQS-0004cV-Tp for ged-emacs-devel@m.gmane.org; Mon, 05 Nov 2018 11:08:28 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJhGA-0002sa-Hn for emacs-devel@gnu.org; Mon, 05 Nov 2018 10:57:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJhG5-0006K3-FT for emacs-devel@gnu.org; Mon, 05 Nov 2018 10:57:50 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJhG1-0005xm-Aa; Mon, 05 Nov 2018 10:57:42 -0500 Original-Received: from [176.228.60.248] (port=4967 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gJhFz-0000Cg-2u; Mon, 05 Nov 2018 10:57:39 -0500 In-reply-to: <20181105105302.GA10520@ACM> (message from Alan Mackenzie on Mon, 5 Nov 2018 10:53:02 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231027 Archived-At: > Date: Mon, 5 Nov 2018 10:53:02 +0000 > From: Alan Mackenzie > Cc: emacs-devel@gnu.org > > The reader would produce, in place of the Lisp_Objects it currently > does, an object with Lisp_Type 1 (which is currently unused). The rest > of the object would be an address pointing at two Lisp_Objects, one > being the "real" read object, the other being a source position. Sounds gross to me. Did you consider using mint_ptr objects instead? That'd be still be gross, but at least we won't introduce another type of Lisp_Object. Also, what about keeping the source position in some other way, like a property of some symbol?