From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Ignore pending_signals when checking for quits.
Date: Sun, 10 Feb 2019 22:15:42 +0200
Message-ID: <83y36nl7rl.fsf@gnu.org>
References: <20190102212218.74902-1-phst@google.com> <83sgy93kkd.fsf@gnu.org>
	<CAArVCkQVL-ZJE=X2vrUQ180btz8kKCNw4cWeWiu+ZOUwg8y9AQ@mail.gmail.com>
	<834l9bmnyc.fsf@gnu.org>
	<CAArVCkRv3yFy7gBeH2ieuxL=5CPLJWo_auhEAkF+vFak4qP_9w@mail.gmail.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="162291"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: phst@google.com, emacs-devel@gnu.org
To: Philipp Stephani <p.stephani2@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 10 21:21:40 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1gsvbf-000g3y-63
	for ged-emacs-devel@m.gmane.org; Sun, 10 Feb 2019 21:21:39 +0100
Original-Received: from localhost ([127.0.0.1]:35090 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1gsvbe-0004hj-2X
	for ged-emacs-devel@m.gmane.org; Sun, 10 Feb 2019 15:21:38 -0500
Original-Received: from eggs.gnu.org ([209.51.188.92]:43319)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1gsvbG-0004TW-Oh
	for emacs-devel@gnu.org; Sun, 10 Feb 2019 15:21:15 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45279)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1gsvWG-0005z1-C1; Sun, 10 Feb 2019 15:16:04 -0500
Original-Received: from [176.228.60.248] (port=2774 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1gsvWE-0006Gq-Kf; Sun, 10 Feb 2019 15:16:04 -0500
In-reply-to: <CAArVCkRv3yFy7gBeH2ieuxL=5CPLJWo_auhEAkF+vFak4qP_9w@mail.gmail.com>
	(message from Philipp Stephani on Sun, 10 Feb 2019 20:46:22 +0100)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:233204
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/233204>

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sun, 10 Feb 2019 20:46:22 +0100
> Cc: Emacs developers <emacs-devel@gnu.org>, Philipp Stephani <phst@google.com>
> 
> > If the only problem is the name, we could change the name.  Or we
> > could introduce a new function.  But let's first agree about the
> > substance: a well-behaving module should from time to time call
> > process_pending_signals.  Agreed?
> 
> Yes, absolutely. We can't change the name (this would break backwards
> compatibility), but introducing a new function would be fine.
> For should_quit itself, I still think we should make the change in
> this patch. The current code is clearly buggy: it promises to quit but
> doesn't in most cases.

I'm okay with such a change if it will be accompanied by introduction
of that new function and suitable changes to the manual which explains
why they are needed.