From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Emacs master build failing on RHEL 6.8
Date: Tue, 07 May 2019 21:20:39 +0300
Message-ID: <83y33ii0so.fsf@gnu.org>
References: <CAFyQvY36pa67zZgJqVYBM4xqLzWr7s_K1U7NfFeysKJTHN7E5Q@mail.gmail.com>
	<ffa07b6e-1803-8cc8-e095-4f4cc4a9b81c@gmx.at>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="109761"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org, kaushal.modi@gmail.com
To: martin rudalics <rudalics@gmx.at>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 07 20:21:55 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hO4iw-000SRe-Nm
	for ged-emacs-devel@m.gmane.org; Tue, 07 May 2019 20:21:55 +0200
Original-Received: from localhost ([127.0.0.1]:51136 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hO4iv-0000rZ-Ea
	for ged-emacs-devel@m.gmane.org; Tue, 07 May 2019 14:21:53 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:44616)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hO4iL-0000rS-7U
	for emacs-devel@gnu.org; Tue, 07 May 2019 14:21:18 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36511)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hO4iI-0007hs-AD; Tue, 07 May 2019 14:21:16 -0400
Original-Received: from [176.228.60.248] (port=2844 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hO4iF-0004kV-HT; Tue, 07 May 2019 14:21:14 -0400
In-reply-to: <ffa07b6e-1803-8cc8-e095-4f4cc4a9b81c@gmx.at> (message from
	martin rudalics on Tue, 7 May 2019 19:37:14 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:236249
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/236249>

> From: martin rudalics <rudalics@gmx.at>
> Date: Tue, 7 May 2019 19:37:14 +0200
> Cc: Paul Eggert <eggert@cs.ucla.edu>
> 
>  > image.c: In function ‘svg_load_image’:
>  > image.c:9468:29: error: missing binary operator before token "("
>  >     #if LIBRSVG_CHECK_VERSION (2, 45, 1) && GNUC_PREREQ (4, 2, 0)
>  >                               ^
>  > make[1]: *** [Makefile:394: image.o] Error 1
> 
> Could this be because LIBRSVG_CHECK_VERSION is defined in
> librsvg-features.h and we include rsvg.h only?

That's how this should be done: rsvg.h includes librsvg-features.h, at
least in my librsvg headers.  librsvg-features.h will print a warning
if you include it directly.