From: Eli Zaretskii <eliz@gnu.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-devel@gnu.org
Subject: Re: Gnus nnir patch for Emacs 26?
Date: Thu, 13 Jun 2019 13:04:19 +0300 [thread overview]
Message-ID: <83y325ztr0.fsf@gnu.org> (raw)
In-Reply-To: <87tvcuscih.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Wed, 12 Jun 2019 14:46:14 -0700)
> From: Eric Abrahamsen <eric@ericabrahamsen.net>
> Date: Wed, 12 Jun 2019 14:46:14 -0700
>
> Someone recently reported a bug in Gnus for searching IMAP groups when
> the group has a non-ascii name. The bug has been there a while, at least
> as far back as Emacs 26. I've attached the diff, which looks large only
> because of indentation changes, it boils down to adding the line:
>
> (setq group (nnimap-decode-gnus-group group))
I didn't understand that this change fixes the problem, the last
message still indicated the patch didn't resolve it. Did you continue
discussing off-list or something? If not, how do you know the fix is
complete?
> Is it too late/too intrusive for Emacs 26? This is the first time
> anyone's reported the bug, so it's obviously not super pressing. Another
> odd thing is that this fix will be unnecessary once the
> scratch/gnus-decoded branch lands, so this change shouldn't go into
> master, but I gather that's possible with a dontmerge cookie or
> something.
If this patch indeed fixes the problem, it's okay for emacs-26, but
please only add that one line, don't reindent anything and don't
replace lambda with its fancier equivalent. Just the minimal required
change.
Thanks.
next prev parent reply other threads:[~2019-06-13 10:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 21:46 Gnus nnir patch for Emacs 26? Eric Abrahamsen
2019-06-13 7:02 ` Robert Pluim
2019-06-13 10:04 ` Eli Zaretskii [this message]
2019-06-13 22:20 ` Eric Abrahamsen
2019-06-14 6:03 ` Eli Zaretskii
2019-06-14 8:18 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y325ztr0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).