From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Native line numbers landed on master
Date: Tue, 01 Oct 2019 12:26:35 +0300
Message-ID: <83y2y4akac.fsf@gnu.org>
References: <83k23jl5ra.fsf@gnu.org> <87bmolqryw.fsf@wavexx.thregr.org>
 <CAAeL0STSHW3Pws7FNNK0PriTLNjM-N3h+wMt9h+bAp_ObrATjA@mail.gmail.com>
 <83blz5bh2m.fsf@gnu.org> <87h88x4fqw.fsf@wavexx.thregr.org>
 <834l4xbfmp.fsf@gnu.org> <87ef414dfn.fsf@wavexx.thregr.org>
 <83o9359w3l.fsf@gnu.org>
 <CAAeL0SSaEF0-FwZ_QCTWPyH+QmK_d=NuKbEMAOsnTGWOiM8eiA@mail.gmail.com>
 <83eezycce5.fsf@gnu.org>
 <CAAeL0SSTEKReisT4PK2QaLiPdt5pCZZqYNWyx_jKo7UdSbjDWw@mail.gmail.com>
 <837e5paqu5.fsf@gnu.org>
 <CAAeL0SSgrcxKMDDO+W0y6cXZXVZSF3Vin-YxBKpQoRf5f-Wc=A@mail.gmail.com>
 <CAAeL0SSS3o2mNYwsbfGag1G6toahqNsF91d2_o87WzE0JCeTvA@mail.gmail.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="68086"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: wavexx@thregr.org, emacs-devel@gnu.org
To: Juanma Barranquero <lekktu@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 01 11:27:38 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1iFERS-000HVR-Io
	for ged-emacs-devel@m.gmane.org; Tue, 01 Oct 2019 11:27:34 +0200
Original-Received: from localhost ([::1]:39622 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1iFERR-0006Nt-Ew
	for ged-emacs-devel@m.gmane.org; Tue, 01 Oct 2019 05:27:33 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35325)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1iFEQW-0006LF-3P
 for emacs-devel@gnu.org; Tue, 01 Oct 2019 05:26:36 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57157)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1iFEQV-0001iR-Vn; Tue, 01 Oct 2019 05:26:36 -0400
Original-Received: from [176.228.60.248] (port=4604 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1iFEQU-0004Qr-H7; Tue, 01 Oct 2019 05:26:34 -0400
In-reply-to: <CAAeL0SSS3o2mNYwsbfGag1G6toahqNsF91d2_o87WzE0JCeTvA@mail.gmail.com>
 (message from Juanma Barranquero on Tue, 1 Oct 2019 10:55:51 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:240427
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/240427>

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Tue, 1 Oct 2019 10:55:51 +0200
> Cc: wavexx@thregr.org, Emacs developers <emacs-devel@gnu.org>
> 
> BTW, this:
> 
>       else if (lnum_to_display % 10 == 0)
>         tem_it.face_id = tenth_lnum_face_id;
>       else if (lnum_to_display % 5 == 0)
>         tem_it.face_id = fifth_lnum_face_id;
>       else
>         tem_it.face_id = lnum_face_id;
> 
> could also be written
> 
>       else if (lnum_to_display % 5 != 0)
>         tem_it.face_id = lnum_face_id;
>       else if (lnum_to_display % 10 == 0)
>         tem_it.face_id = tenth_lnum_face_id;
>       else /* lnum_to_display % 5 == 0 */
>         tem_it.face_id = fifth_lnum_face_id;
> 
> with the idea that 80% of lines fall into the linum_face_id case, so it's better to have it first. But I suspect it's a
> micro-optimization best left to modern compilers.

I'm okay with either version.