Re: Escaping a string for substitute-command-keys

[Eli Zaretskii <eliz@gnu.org>]

> Cc: emacs-devel@gnu.org
> From: Clément Pit-Claudel <cpitclaudel@gmail.com>
> Date: Sat, 5 Oct 2019 04:04:34 -0400
> 
> > I guess we need to add some feature to control whether help-echo gets
> > run through substitute-command-keys, or add an alternative to
> > help-echo that works exactly like it, but without substitutions.
> > Patches welcome.
> 
> Sounds good, and I can work on the patch.  I think I like the first solution better, if we can come up with something elegant: the second case will force us to define priorities, and besides we already have kbd-help in addition to help-echo.
> 
> What about the following: before performing a conversion, substitute-command-keys could check a property of the string that it receives, say help-echo-conversion, and if that property is nil it would not perform the conversion.

I'd prefer a property like help-echo-inhibit-substitution that is
non-nil, to inhibit the call to substitute-command-keys.  A value of
nil is easy to confuse with no property at all.

> Alternatively, there's the option of performing conversion only on those 'help-echo' properties that are string, and leaving (the output of) the ones that are functions untouched.

I think they all should be converted, otherwise we have an
inconsistency of the kind you mentioned.