From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: ai_flags in calls to getaddrinfo, broader call for reproducibility check Date: Mon, 11 Jan 2021 22:41:43 +0200 Message-ID: <83y2gzdx4o.fsf@gnu.org> References: <83sg7mggls.fsf@gnu.org> <83czymc8nq.fsf@gnu.org> <74b7a0a9-0eb3-7944-19d2-f72424ee72d7@dasyatidae.com> <83eeirfqbo.fsf@gnu.org> <87o8hvscfi.fsf@gmail.com> <8335z7fmnz.fsf@gnu.org> <87ft374axc.fsf@gmail.com> <5cb6a0ac-9fe9-bfc2-5642-3423bd043238@dasyatidae.com> <8735z748p1.fsf@gmail.com> <87y2gz2pxf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22175"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, rtt@dasyatidae.com, emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 11 21:43:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kz41o-0005fF-G8 for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Jan 2021 21:43:04 +0100 Original-Received: from localhost ([::1]:46164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kz41n-0002E8-JE for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Jan 2021 15:43:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kz40O-0001ip-BY for emacs-devel@gnu.org; Mon, 11 Jan 2021 15:41:37 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44856) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kz40M-0003Ji-I0; Mon, 11 Jan 2021 15:41:34 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1842 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kz40M-0001XW-1Q; Mon, 11 Jan 2021 15:41:34 -0500 In-Reply-To: <87y2gz2pxf.fsf@gmail.com> (message from Robert Pluim on Mon, 11 Jan 2021 21:12:44 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262933 Archived-At: > From: Robert Pluim > Cc: Robin Tarsiger , Eli Zaretskii , > emacs-devel@gnu.org > Date: Mon, 11 Jan 2021 21:12:44 +0100 > > Stefan Monnier writes: > > >> Because the select implementation on windows does a one-byte readahead > >> to see if data is available, which breaks UDP. I had a patch at one > >> point to fix this, but I remember Eli not being very enthusiastic > >> about it. Iʼve attached what I think is the right version below (my > >> windows box died, so I can't be sure) > > > > How 'bout installing it but make it conditional on some config var? > > And maybe set that config var if/when a UDP socket is requested? > > I guess thatʼs possible. Iʼve now found the actual patch. If Eli > thinks itʼs worth persuing, I can make it conditional, unless someone > wants to spare me the trouble of setting up a working Windows dev > environment :-). My main concern is who will investigate the bug reports about this, debug the problem, find fixes, etc.? If you or Stefan or someone else volunteers, then please go ahead. But if you count on me, implicitly or otherwise, then let's wait for a volunteer to emerge. Especially in this area, where I'm far from being an expert. Don't forget that two threads are involved in this game, which provides ample opportunity for exciting deadlocks and races, apart of network-specific issues. (I'm sorry, but too often lately I'm the only one who gets to debug and fix MS-Windows specific issues; if I don't do that, the build remains broken for days. It's too much of a burden on me, and takes a significant enough fraction of my time that I must be very cautious with adventures. Otherwise, I won't be able to do my main job here, which I already am barely capable of doing.)