From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master 289000e: Merge branch 'feature/native-comp' into trunk
Date: Sun, 25 Apr 2021 23:25:28 +0300
Message-ID: <83y2d6jemf.fsf@gnu.org>
References: <20210425182503.25223.81072@vcs0.savannah.gnu.org>
 <20210425182508.6CC7C2094D@vcs0.savannah.gnu.org>
 <xjfbla26wk9.fsf_-_@sdf.org> <835z0aky14.fsf@gnu.org>
 <xjf7dkq6vhf.fsf@sdf.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="35753"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Andrea Corallo <akrl@sdf.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 25 22:26:52 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lalLA-0009Ch-0C
	for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Apr 2021 22:26:52 +0200
Original-Received: from localhost ([::1]:41884 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lalL9-0000z1-3h
	for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Apr 2021 16:26:51 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43516)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1lalK9-0000YY-UI
 for emacs-devel@gnu.org; Sun, 25 Apr 2021 16:25:49 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42794)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1lalK8-0007eU-IE; Sun, 25 Apr 2021 16:25:48 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2086
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1lalK7-0007QP-Kl; Sun, 25 Apr 2021 16:25:48 -0400
In-Reply-To: <xjf7dkq6vhf.fsf@sdf.org> (message from Andrea Corallo on Sun, 25
 Apr 2021 18:59:40 +0000)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:268423
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/268423>

> From: Andrea Corallo <akrl@sdf.org>
> Cc: emacs-devel@gnu.org
> Date: Sun, 25 Apr 2021 18:59:40 +0000
> 
> >   In normal-top-level:
> >   startup.el:649:26: Warning: assignment to free variable `comp-eln-load-path'
> 
> Fixed, thanks.

Thanks, confirmed.

One thing that I think we should improve is that comp.el and
comp-cstr.el get native-compiled when COMPILE_FIRST files are
recompiled, but not when comp.el or comp-cstr.el are modified.  In the
latter case, they are just byte-compiled, leaving stale *.eln files in
native-lisp/.  This requires to compile them manually each time, an
annoyance.  I guess some Make wizardry is in order.