From: Eli Zaretskii <eliz@gnu.org>
To: Anand Tamariya <atamariya@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Unicode combining characters
Date: Thu, 27 May 2021 12:40:45 +0300 [thread overview]
Message-ID: <83y2c08qg2.fsf@gnu.org> (raw)
In-Reply-To: <CADm7Y4kLTQzw-_SU20z-q0wktfEw28Q0B7CCOpeVKc63pM5BeA@mail.gmail.com> (message from Anand Tamariya on Thu, 27 May 2021 12:30:04 +0530)
> From: Anand Tamariya <atamariya@gmail.com>
> Date: Thu, 27 May 2021 12:30:04 +0530
> Cc: emacs-devel@gnu.org
>
> Please try the latest master branch, I hope I fixed this now.
>
> The fix works for the given example. However, here's another one that ideally should be one composed glyph
> (validated by moving the cursor over the glyph) but counts as 2 in string-width.
>
> (setq ra (string 2352 2366))
>
> (string-width ra) ; 2
OK, I improved this case now on master, please take a look.
However, please note that getting this right makes string-width more
dependent on the selected-frame's font used by the default face for
the characters of the string. In particular, if that font is unable
to combine the characters that should be composed, you will now get
width which could be different from the value on other frames with
other fonts. Also, the new code only works in interactive sessions on
GUI frames, because we need the shaping engine (a.k.a. "font driver")
to compose characters.
next prev parent reply other threads:[~2021-05-27 9:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 15:56 Unicode combining characters Anand Tamariya
2021-05-25 17:22 ` Stefan Monnier
2021-05-25 17:24 ` Eli Zaretskii
2021-05-25 18:15 ` Clément Pit-Claudel
2021-05-25 18:39 ` Eli Zaretskii
2021-05-25 19:30 ` Clément Pit-Claudel
2021-05-25 19:44 ` Eli Zaretskii
2021-05-26 9:51 ` Anand Tamariya
2021-05-26 10:04 ` Joost Kremers
2021-05-26 12:54 ` Eli Zaretskii
2021-05-26 17:14 ` Eli Zaretskii
2021-05-27 7:00 ` Anand Tamariya
2021-05-27 9:40 ` Eli Zaretskii [this message]
2021-05-27 10:34 ` Basil L. Contovounesios
2021-05-27 12:30 ` Eli Zaretskii
2021-05-27 13:27 ` Anand Tamariya
2021-05-27 13:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y2c08qg2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=atamariya@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).