From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Highlight current line when using gud Date: Wed, 30 Jun 2021 15:27:03 +0300 Message-ID: <83y2armtbc.fsf@gnu.org> References: <46933061-DFBC-406C-8489-F3DC7EE770BA@kuaishou.com> <87sg0z8t5t.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35392"; mail-complaints-to="usenet@ciao.gmane.io" Cc: condy0919@gmail.com, chenzhiwei03@kuaishou.com, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 30 14:28:07 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lyZK3-000934-I5 for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Jun 2021 14:28:07 +0200 Original-Received: from localhost ([::1]:43952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyZK2-0000pW-C1 for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Jun 2021 08:28:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyZJ3-00007T-Up for emacs-devel@gnu.org; Wed, 30 Jun 2021 08:27:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36498) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyZJ2-0008QS-6Y; Wed, 30 Jun 2021 08:27:04 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3682 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyZJ1-0007Cq-QE; Wed, 30 Jun 2021 08:27:04 -0400 In-Reply-To: <87sg0z8t5t.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 30 Jun 2021 13:54:06 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271081 Archived-At: > From: Lars Ingebrigtsen > Date: Wed, 30 Jun 2021 13:54:06 +0200 > Cc: Zhiwei Chen , emacs-devel > > Condy Chen writes: > > > Before this patch, dark theme users cannot distinguish the line from the > > background even though hl-line-mode is enabled. Personally I can't. > > I'm not sure I understand the problem here -- hl-line-mode works fine > for me when using a dark background. Right, I wondered about that myself. If some themes make the highlighted current line hard to see, that's a problem with the face definition of those themes. > > Furthermore, users must set hl-line-sticky-flag to t to enable > > highlight in all windows or move the point to the source file buffer, > > otherwise only the arrow in fringe is helpful for which line program > > run to. It's too restricted in such a situation. > > > > So I propose to add a new overlay of current line to make gud more > > friendly and deprecate the old one. > > The patch seems to add a new overlay mechanism for gud that's switched > on for all people? And is "the old one" you want to deprecate > hl-line-mode? FWIW, I'm not opposed to such a change, but it must be an optional feature (we could discuss the default value). I don't think we can force people to use this overlay. Especially since on GUI displays the arrow is shown in the fringe (not to mention the fact that gud-gdb is deprecated in favor of gdb-mi.el).