From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: condy0919@gmail.com, chenzhiwei03@kuaishou.com, emacs-devel@gnu.org
Subject: Re: Highlight current line when using gud
Date: Wed, 30 Jun 2021 15:27:03 +0300 [thread overview]
Message-ID: <83y2armtbc.fsf@gnu.org> (raw)
In-Reply-To: <87sg0z8t5t.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 30 Jun 2021 13:54:06 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Wed, 30 Jun 2021 13:54:06 +0200
> Cc: Zhiwei Chen <chenzhiwei03@kuaishou.com>, emacs-devel <emacs-devel@gnu.org>
>
> Condy Chen <condy0919@gmail.com> writes:
>
> > Before this patch, dark theme users cannot distinguish the line from the
> > background even though hl-line-mode is enabled. Personally I can't.
>
> I'm not sure I understand the problem here -- hl-line-mode works fine
> for me when using a dark background.
Right, I wondered about that myself. If some themes make the
highlighted current line hard to see, that's a problem with the face
definition of those themes.
> > Furthermore, users must set hl-line-sticky-flag to t to enable
> > highlight in all windows or move the point to the source file buffer,
> > otherwise only the arrow in fringe is helpful for which line program
> > run to. It's too restricted in such a situation.
> >
> > So I propose to add a new overlay of current line to make gud more
> > friendly and deprecate the old one.
>
> The patch seems to add a new overlay mechanism for gud that's switched
> on for all people? And is "the old one" you want to deprecate
> hl-line-mode?
FWIW, I'm not opposed to such a change, but it must be an optional
feature (we could discuss the default value). I don't think we can
force people to use this overlay. Especially since on GUI displays
the arrow is shown in the fringe (not to mention the fact that
gud-gdb is deprecated in favor of gdb-mi.el).
next prev parent reply other threads:[~2021-06-30 12:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 12:43 Highlight current line when using gud Zhiwei Chen
2021-06-29 20:00 ` Condy Chen
2021-06-30 11:54 ` Lars Ingebrigtsen
2021-06-30 12:27 ` Eli Zaretskii [this message]
2021-06-30 13:07 ` Zhiwei Chen
2021-06-30 12:53 ` Zhiwei Chen
2021-06-30 12:59 ` Zhiwei Chen
2021-06-30 13:18 ` Eli Zaretskii
2021-06-30 13:17 ` Eli Zaretskii
2021-06-30 14:26 ` Zhiwei Chen
2021-06-30 15:50 ` Eli Zaretskii
2021-07-01 3:17 ` Zhiwei Chen
2021-07-01 11:26 ` Lars Ingebrigtsen
2021-07-01 11:35 ` Zhiwei Chen
2021-07-01 17:27 ` Condy Chen
2021-07-01 18:25 ` Zhiwei Chen
2021-07-02 11:01 ` Lars Ingebrigtsen
2021-07-02 11:39 ` Eli Zaretskii
2021-07-04 0:12 ` Zhiwei Chen
2021-07-04 4:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y2armtbc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=chenzhiwei03@kuaishou.com \
--cc=condy0919@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).