From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: bug#49822: master e32c7d2: Change Python eval to send directly instead of using temporary files Date: Tue, 07 Sep 2021 20:48:21 +0300 Message-ID: <83y288nuoq.fsf@gnu.org> References: <20210903122828.16890.65271@vcs0.savannah.gnu.org> <20210903122829.EAAC220B71@vcs0.savannah.gnu.org> <87r1e4eklw.fsf@gmail.com> <87v93fnfmm.fsf@igel.home> <87lf4aooge.fsf@gmail.com> <878s0a409g.fsf@gmx.de> <87ilzef65i.fsf@igel.home> <878s0aeyna.fsf@gmx.de> <87r1e1ex7z.fsf@igel.home> <875yvcmgm2.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17193"; mail-complaints-to="usenet@ciao.gmane.io" Cc: andrewjmoreton@gmail.com, Mark.Barton@disney.com, emacs-devel@gnu.org, schwab@linux-m68k.org, monnier@iro.umontreal.ca, 49822@debbugs.gnu.org, michael.albinus@gmx.de, larsi@gnus.org To: Augusto Stoffel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 07 19:49:29 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNfDt-0004IZ-Ht for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Sep 2021 19:49:29 +0200 Original-Received: from localhost ([::1]:52760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNfDs-0004Ob-DO for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Sep 2021 13:49:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNfCj-0003Bi-Aw for emacs-devel@gnu.org; Tue, 07 Sep 2021 13:48:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59106) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNfCh-0005qz-G0; Tue, 07 Sep 2021 13:48:15 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4512 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNfCg-0003Fi-V6; Tue, 07 Sep 2021 13:48:15 -0400 In-Reply-To: <875yvcmgm2.fsf@gmail.com> (message from Augusto Stoffel on Tue, 07 Sep 2021 19:37:41 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274276 Archived-At: > From: Augusto Stoffel > Date: Tue, 07 Sep 2021 19:37:41 +0200 > Cc: Andy Moreton , emacs-devel@gnu.org, > Andreas Schwab , > Stefan Monnier , 49822@debbugs.gnu.org, > Michael Albinus , Lars Ingebrigtsen > > Okay then. Since there seem to be no better alternatives, I have > attached a new patch reducing the limit to a hard-coded 1024 bytes. If > some day someone adds a variable specifying a more precise limit, then > we can change this. I thought the conclusion was that we do know the limits, but they are different on different OSes? If so, why not use the correct limit for each OS, instead of using the most strict limit? The underlying OS is available in system-type. > - (if (<= (string-bytes code) 4096) > + (if (<= (string-bytes code) 1024) In any case, IMO this should be a defconst with a suitable doc string, so that we'd have this stuff documented for posterity. Thanks.