From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master ec0527d 1/4: Use command substitution for exit-recursive-edit Date: Sun, 19 Sep 2021 09:00:43 +0300 Message-ID: <83y27t3y0k.fsf@gnu.org> References: <20210918214238.18205.26241@vcs0.savannah.gnu.org> <20210918214240.0C2FF20ABE@vcs0.savannah.gnu.org> <875yuxmran.fsf@igel.home> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4493"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefan@marxist.se, emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 19 08:03:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRpuq-00010L-Fa for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Sep 2021 08:03:04 +0200 Original-Received: from localhost ([::1]:60122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRpup-0002Zd-CB for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Sep 2021 02:03:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRpsw-0001bO-Qq for emacs-devel@gnu.org; Sun, 19 Sep 2021 02:01:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47210) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRpsw-0002TT-5Q; Sun, 19 Sep 2021 02:01:06 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4716 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRpsk-0006T6-A3; Sun, 19 Sep 2021 02:00:55 -0400 In-Reply-To: <875yuxmran.fsf@igel.home> (message from Andreas Schwab on Sun, 19 Sep 2021 00:50:56 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275042 Archived-At: > From: Andreas Schwab > Date: Sun, 19 Sep 2021 00:50:56 +0200 > Cc: Stefan Kangas > > On Sep 18 2021, Stefan Kangas wrote: > > > branch: master > > commit ec0527d8e9a7f12898c8fe9fdb6daec21c1d2ba8 > > Author: Stefan Kangas > > Commit: Stefan Kangas > > > > Use command substitution for exit-recursive-edit > > This breaks bootstrap. Something to remember when moving code from C to Lisp: it might introduce ticking time bombs into loadup.el. Stefan, I see you reverted the change, but an alternative could be to move loading of bindings.el in loadup.el to after help.el, or move help.el before bindings.el. If this doesn't break the build, it could be an okay solution (but please add a comment about the order dependency there). Alternatively, you could modify the value of mod-line-modes in startup.el.