From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Checking before removing obsolete comment about memmove. Date: Sun, 28 Nov 2021 10:46:18 +0200 Message-ID: <83y258wtut.fsf@gnu.org> References: <87h7bwpu34.fsf@red-bean.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9255"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 28 09:47:24 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrFqG-0002EG-Hz for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Nov 2021 09:47:24 +0100 Original-Received: from localhost ([::1]:54626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrFqF-0000aT-CW for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Nov 2021 03:47:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrFp3-0007hi-QX for emacs-devel@gnu.org; Sun, 28 Nov 2021 03:46:10 -0500 Original-Received: from [2001:470:142:3::e] (port=56300 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrFp3-0004zp-7h; Sun, 28 Nov 2021 03:46:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CHYbkAF0EXYgWVjJhtJpQGHD0rC4bZDwIobznK4onpA=; b=eeuxmEdBqNoe dR/JmmRtlZzuDYoK+gZk/j7Ax6J958zkY0SlPgJbfg9V6Vd/p32zEpMCPyE8atRAtN5gLybkkMdHO eEeIYAqdf6j3TxyMjmLeJBPsjbQlRA7LhxcBBs7PTk1Z9nUTxOlLsELInMwStJic/zuSzZrkAP+8z SPAIuLP70rXITtIyI2ZhGzEf37nGzi2bBEOxuAIB+T8408QYpFJtGXJvc/GxFhBjR68HIbbcA3S9v hzk+wvP9D0AVqAUxHN3/njISkXNqbkTPQSOWKYiHNlyMojpUZDvrZjRHSjZr0gjLDnPYfUuwwSqnY n8GsIoTO2azY3cvU0M+ZrQ==; Original-Received: from [87.69.77.57] (port=1055 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrFp2-0003H5-9e; Sun, 28 Nov 2021 03:46:09 -0500 In-Reply-To: <87h7bwpu34.fsf@red-bean.com> (message from Karl Fogel on Sun, 28 Nov 2021 02:23:11 -0600) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280390 Archived-At: > From: Karl Fogel > Date: Sun, 28 Nov 2021 02:23:11 -0600 > > In src/editfns.c, in Ftranspose_regions, I'd like to remove this > obsolete comment: > > /* Working without memmove, for portability (sigh), so must be > careful of overlapping subsections of the array... */ > > We now use memmove() in that function since [1], just as we now > use memmove() in many other places in Emacs. Feel free to do that (on the emacs-28 branch, please).