From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [C source] Inconsistent comments on preprocessor conditionals Date: Fri, 08 Jul 2022 16:37:21 +0300 Message-ID: <83y1x33eum.fsf@gnu.org> References: <87sfnb3h5m.fsf@disroot.org> <8335fb4vc7.fsf@gnu.org> <6feb2ce2c5e249b74e836edd3ba0c7a0@webmail.orcon.net.nz> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13579"; mail-complaints-to="usenet@ciao.gmane.io" Cc: akib@disroot.org, emacs-devel@gnu.org To: Phil Sainty Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 08 15:39:13 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9oCP-0003HO-CO for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Jul 2022 15:39:13 +0200 Original-Received: from localhost ([::1]:50088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9oCN-00054o-Si for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Jul 2022 09:39:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9oAe-0003UU-DP for emacs-devel@gnu.org; Fri, 08 Jul 2022 09:37:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42924) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9oAe-0007wz-0A; Fri, 08 Jul 2022 09:37:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nZ9RnkLef06t/497dQass/UgKwIMxVKH4zAZL+cN8eo=; b=W59H1ntK3UMb s/Xnu+ITRKE96xJ3lA9FDSPPudRrLFrU8dP8zTATcONm5JEFOfA6qEvJYwpsuQqVyFCuXvWBq74bg Nyy9qwHC4GjrhHVwqqN6RoPvftUM+90v1dO5Cx+GoyvJ34jG/ZJkGBg8V+LwentX5HpDI40ajPc62 7VvlT8BaIylwjQL0HKsSWHYbX2ajkY2OhZAPIljMwI8EM/TWzDJQba6F9EX4MqwyUoB1ICO6K/M/g eS345VDa+x3S92E7JIutcDPvzFvCZ6nSgWr2bOtvlDjd8uyQJiq+4ZwEft/ouaQL9KlXmzJMaZsEB udOPcAsA5sHndCZi8W6kmg==; Original-Received: from [87.69.77.57] (port=1817 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9oAd-0008NZ-CV; Fri, 08 Jul 2022 09:37:23 -0400 In-Reply-To: <6feb2ce2c5e249b74e836edd3ba0c7a0@webmail.orcon.net.nz> (message from Phil Sainty on Sat, 09 Jul 2022 01:33:26 +1200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291965 Archived-At: > Date: Sat, 09 Jul 2022 01:33:26 +1200 > From: Phil Sainty > Cc: Akib Azmain Turja , emacs-devel@gnu.org > > On 2022-07-09 00:55, Eli Zaretskii wrote: > > You mean, the comment for the #endif line? It doesn't really matter > > how you comment that, because both comments tell the same: the > > #ifdef'ed conditional block ends here. The differences in this case > > are purely stylistic. > > The "#endif /* not FOO */" version provides the extra information that > there *is* an "#else" clause No, it doesn't, because the conditional could start with #ifndef instead.