From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Progress for bug#59314 for emacs-29 Date: Wed, 21 Dec 2022 15:46:03 +0200 Message-ID: <83y1r0amzo.fsf@gnu.org> References: <83cz8dar7z.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7289"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, alexander.adolf@condition-alpha.com To: Thomas Fitzsimmons Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 21 14:46:49 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7zQn-0001eO-07 for ged-emacs-devel@m.gmane-mx.org; Wed, 21 Dec 2022 14:46:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7zQB-0007Qm-9W; Wed, 21 Dec 2022 08:46:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7zQ9-0007PF-L4 for emacs-devel@gnu.org; Wed, 21 Dec 2022 08:46:09 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7zQ8-0003MX-Ur; Wed, 21 Dec 2022 08:46:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=l6EAePwoOPW87+iw6DufNa1wUamml6FxdoEsk+i8SHs=; b=V/Y2IxjQCWVe jtRAS9YGijqLSvd8B/WbTlF6AYCUwFj/P1rHPM/dvE7VIa+g6LSzz/fHxF5g52956e0W++V6qJufr AHWLCs3nxu7eX1L/tbAPx/zqp78m6VPN6YGUbOYYmwDgJjSWi3w0mhuoaZnIoY5FIqCJpCng06eFR pd80nferHJeEt+z5sxrVilmzJrX0xaU70QN8gJu0yyub+hDJYnpYGmeAtS6G8LftIIqrEWaW3HEQt 7h2s+A/jhwMobgVvSHjL7tFSOOoH02ZRZY48yJRsNCoFGeYI0i3blBHesme4IaQwI/LKRl8tUcHNf ax296QMx+9g6PdK6XVhfeg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7zQ8-0001Bv-5w; Wed, 21 Dec 2022 08:46:08 -0500 In-Reply-To: (message from Thomas Fitzsimmons on Wed, 21 Dec 2022 07:54:56 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301748 Archived-At: > From: Thomas Fitzsimmons > Cc: emacs-devel@gnu.org, alexander.adolf@condition-alpha.com > Date: Wed, 21 Dec 2022 07:54:56 -0500 > > Eli Zaretskii writes: > > >> From: Thomas Fitzsimmons > >> Cc: Alexander Adolf > >> Date: Tue, 20 Dec 2022 21:59:41 -0500 > >> > >> Alexander posted the attached patch, which helps with bug#59314. Can I > >> push it to the emacs-29 branch? > > > > Is this a bug or just a lack of a nice-to-have feature? If the > > former, since when do we have this bug? > > > > Also, I'd like to reassess this once you have a final version, per > > Stefan's comments, which avoids tramping a user option. > > OK. The issue itself, a regression, is fixed by just this part of the > patch (see long discussion on the bug report): > > diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el > index e7d11b597b3..6c10a4ae976 100644 > --- a/lisp/gnus/message.el > +++ b/lisp/gnus/message.el > @@ -3191,7 +3191,6 @@ message-mode > (mail-abbrevs-setup)) > ((message-mail-alias-type-p 'ecomplete) > (ecomplete-setup))) > - (add-hook 'completion-at-point-functions #'eudc-capf-complete -1 t) > (add-hook 'completion-at-point-functions #'message-completion-function nil t) > (unless buffer-file-name > (message-set-auto-save-file-name)) > > Can I push that? Yes, thanks.