From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] * etc/NEWS: Announce addition of BOM to utf-8-auto Date: Sun, 29 Jan 2023 21:38:54 +0200 Message-ID: <83y1pl5dwx.fsf@gnu.org> References: <837cx56vpc.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20010"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Tom Gillespie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 29 20:39:52 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMDWp-00051Z-TF for ged-emacs-devel@m.gmane-mx.org; Sun, 29 Jan 2023 20:39:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMDW6-0000ln-6t; Sun, 29 Jan 2023 14:39:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMDW5-0000lf-6a for emacs-devel@gnu.org; Sun, 29 Jan 2023 14:39:05 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMDW2-0008Gm-IO; Sun, 29 Jan 2023 14:39:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0CMJThQ4ANsNoHfo20/tezcDvteOUENfvr8wRZKfbLQ=; b=f6rM9nokpmFi mRjuoLxoSmagH054brxwLIVagKgm5YQBUxuR8t73GxXhhFByb7YGr96C1VJElxxrGHUwiljtXhidk ja9RkHSgniFGJkdCkQD958AmmSJ1kVjCKh6ApOzrS+zBgg+9U4OJQmd4V7vqHJIiEPDkJpSXVMv// F7ULBD/FsWelscMupsyPjaEITMm4x2zBTpeIXV6Gw+wl+SqReTqMDB/DquLeukH/17MGgGT/25cBE 3O4HS3tu0Qz5QwfEjzF87Wj2TJzGr2zCqbVaMy4lnDNSZ+hhcYfAbrXvvDMt05yWL1ovduCAlTk4O sqJTFQWI2zAV60mIF84X0w==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMDW1-0007vC-OZ; Sun, 29 Jan 2023 14:39:02 -0500 In-Reply-To: (message from Tom Gillespie on Sun, 29 Jan 2023 14:11:13 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302761 Archived-At: > From: Tom Gillespie > Date: Sun, 29 Jan 2023 14:11:13 -0500 > Cc: emacs-devel@gnu.org > > > > +** The 'utf-8-auto' coding-system now includes a byte order mark > > > > This is inaccurate: the change is only on encoding, and saying that a > > coding-system "includes" a BOM is confusing English, IMO. > > Hrm. I agree. Would it be better to say something like the following? > > "Encoding 'utf-8-auto' now correctly produces a byte order mark" Encoding with 'utf-8-auto' now correctly produces a byte order mark. > > More importantly, it was a bugfix. utf-8-auto was previously behaving > > contrary to the documentation: > > We don't announce bugfixes in NEWS, mainly because doing so would make > > an already large file many times larger. > > I understand that this is technically a bugfix, but it is also a major > change in the actual behavior that could catch users by surprise > and that is very difficult to detect and debug. Is it reasonable to > use NEWS to try to mitigate the potential blast radius in such cases? Maybe (you assume that people really read all the small print in NEWS?). But first, could you explain why on earth are you using utf-8-auto _on_encoding_? It basically makes no sense at all. All the people who did that with whom I talked until now did it because they thought the "auto" part was about the EOL format (CR-LF vs Newline). Is that so in your case as well?