From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Eglot "inlay hints" landed Date: Thu, 23 Feb 2023 16:48:59 +0200 Message-ID: <83y1oophd0.fsf@gnu.org> References: <83edqqaf8c.fsf@gnu.org> <2B284D77-97DF-4B3E-89FB-13F0CA93D240@gmail.com> <87356xv65z.fsf_-_@gmail.com> <83fsawriye.fsf@gnu.org> <835ybsr6aa.fsf@gnu.org> <83356wr224.fsf@gnu.org> <87bklktu89.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21174"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dalal.chinmay.0101@gmail.com, emacs-devel@gnu.org, dimitri@belopopsky.com, luangruo@yahoo.com To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 23 15:49:24 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVCuQ-0005CJ-2U for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Feb 2023 15:49:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVCu9-00084e-Ld; Thu, 23 Feb 2023 09:49:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVCu7-00084B-KB for emacs-devel@gnu.org; Thu, 23 Feb 2023 09:49:03 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVCu7-00026N-2y; Thu, 23 Feb 2023 09:49:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=QRsj1490Z9oOIi8E7NGwcQ00hWXxuRw7rp5sXTB68i8=; b=YndTfY7h+gHWqbL3jreo sl2QfCRH2rRgScbhEriNkIArUiQOEhPMIm7PaODgi6CqqgQC4McfURrbg2IQceCeUVPGv9nIRyuDr 49aKj93/rkfVnTCadKDNGVaHY3pMvVSVt71mfxOSamMxGNVUaem0TQ11HqYa4kBEE41lOXWRk0+Ax wnEjqALfldoeKjvY/SKldbTiSSqpuFs7PcPfwKfGTKVMnVPOENh+tbI7IkFbrcTuDINSBkHngkmoU aRxaV+ir3e2AauErD9gYP9IWywRwDXSPMgVXHkbqjM/lRPq/xihvGv65gnYBxr56MhbajW6mE9jaE 7ePvCL0Wwi1zCQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVCu6-0000ot-Au; Thu, 23 Feb 2023 09:49:02 -0500 In-Reply-To: <87bklktu89.fsf@gmail.com> (message from =?utf-8?B?Sm/Do28g?= =?utf-8?B?VMOhdm9yYQ==?= on Thu, 23 Feb 2023 12:57:26 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303706 Archived-At: > From: João Távora > Cc: dalal.chinmay.0101@gmail.com, emacs-devel@gnu.org, > dimitri@belopopsky.com, luangruo@yahoo.com > Date: Thu, 23 Feb 2023 12:57:26 +0000 > > Eli Zaretskii writes: > > > We don't need to make the overlays until the buffer is shown in some > > window, right? > > Yes, but two buffers A and B might already be showing in some window. > If you do the change in buffer A and it affects B, then in the current > version, the parts of A being show in windows will be updated, but B the > parts of B being shown in some other windows will not. If there's a change in A that affects B, jit-lock will call fontification-functions in both A and B, each one when it's about to display the corresponding window. > PS: On an unrelated note, I pushed this to emacs-29. If you wish me to > revert the inlay hints implementation and do all this work in master, > it's fine by me. emacs-29 is fine, thanks.