From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: Change to `use-dialog-box-p'
Date: Sat, 20 May 2023 08:56:12 +0300 [thread overview]
Message-ID: <83y1ljsg03.fsf@gnu.org> (raw)
In-Reply-To: <87o7mf3em6.fsf@yahoo.com> (message from Po Lu on Sat, 20 May 2023 10:45:21 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Date: Sat, 20 May 2023 10:45:21 +0800
>
> After:
>
> 2023-04-02 Eli Zaretskii <eliz@gnu.org>
>
> * lisp/subr.el (use-dialog-box-p): Fix conditions for GUI dialogs.
>
> dialog boxes will no longer be used when there is no last input event at
> all, i.e. when `last-nonmenu-event' is nil.
>
> Previously, `use-dialog-box-p' would only return nil if
> `last-nonmenu-event' was a key event, which is the correct behavior;
> `Fyes_or_no_p' still uses the correct test.
>
> Why was that change made?
Because last-nonmenu-event being nil happens in too many cases where
showing the GUI dialog is not TRT. Immediately after startup, for
example.
What is the situation where you need to show a GUI dialog even though
last-nonmenu-event is nil?
next prev parent reply other threads:[~2023-05-20 5:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87o7mf3em6.fsf.ref@yahoo.com>
2023-05-20 2:45 ` Change to `use-dialog-box-p' Po Lu
2023-05-20 5:56 ` Eli Zaretskii [this message]
2023-05-20 6:29 ` Po Lu
2023-05-20 8:14 ` Eli Zaretskii
2023-05-20 8:32 ` Po Lu
2023-05-20 9:41 ` Eli Zaretskii
2023-05-20 11:17 ` Po Lu
2023-05-20 12:38 ` Eli Zaretskii
2023-05-21 0:47 ` Po Lu
2023-05-21 5:50 ` Eli Zaretskii
2023-05-21 6:41 ` Po Lu
2023-05-21 7:40 ` Eli Zaretskii
2023-05-22 5:33 Pedro A. Aranda Gutiérrez
2023-05-22 9:27 ` Po Lu
2023-05-22 10:17 ` Pedro Andres Aranda Gutierrez
2023-05-22 11:28 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2023-05-23 1:39 Samuel Wales
2023-05-23 11:35 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y1ljsg03.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).