From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: ChangeLog and commit messages Date: Fri, 23 Jun 2023 10:16:07 +0300 Message-ID: <83y1ka1weg.fsf@gnu.org> References: <87a5wxb5sl.fsf.ref@yahoo.com> <87a5wxb5sl.fsf@yahoo.com> <837cs1p6bf.fsf@gnu.org> <875y7lb4k7.fsf@yahoo.com> <327d575ab075bf4e92ca00c11548a62458fec75b.camel@yandex.ru> <87r0q86zvd.fsf@yahoo.com> <87jzw06j1y.fsf@yahoo.com> <834jn38l8t.fsf@gnu.org> <87ttuyvfhv.fsf@melete.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3146"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, hi-angel@yandex.ru, emacs-devel@gnu.org To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 23 09:16:14 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qCb1i-0000fp-C3 for ged-emacs-devel@m.gmane-mx.org; Fri, 23 Jun 2023 09:16:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qCb1R-000511-Pl; Fri, 23 Jun 2023 03:15:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCb1Q-00050s-O3 for emacs-devel@gnu.org; Fri, 23 Jun 2023 03:15:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCb1P-0001W9-VA; Fri, 23 Jun 2023 03:15:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iclu33hNH59j824uHuLncx4DwnCOFhZMy8kUCThreaM=; b=du/ULiZ8yWmL G/g/wAxDjbHfQW/NbGj3LToNBErkiC2mB2zY14zfDwTLo9vS0zNwg1JTeE7zLmvEKyGcZc4jnd2xg daGK2OkwPmE9SeNE/CtUT/coVLd3/g5O6Tg/inLJ7xiz2DmO83d/wntFd/CN94igr3GAjZRaoqTR3 bfgPd3kHPjxChf/XQVToeinGF9cVZKnAQcMTk2UAohGeGrN73bDOAhQ+xmkk9M6EuRufyuHK1c00L UQjN/TS0m+nz9j3po0ESATLjq3VohoSCc06B5n/a3t0AsCRWkFkmJiiOz8fMQ8Edyreft5OD9a35O /6rjOn7sv/L7C8eV8ddtkw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCb1P-0004yN-EJ; Fri, 23 Jun 2023 03:15:55 -0400 In-Reply-To: <87ttuyvfhv.fsf@melete.silentflame.com> (message from Sean Whitton on Fri, 23 Jun 2023 07:50:52 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307151 Archived-At: > From: Sean Whitton > Cc: Po Lu , hi-angel@yandex.ru, emacs-devel@gnu.org > Date: Fri, 23 Jun 2023 07:50:52 +0100 > > Hello, > > On Mon 19 Jun 2023 at 07:33PM +03, Eli Zaretskii wrote: > > > If your problems are with the feature branch, then I think you are > > making your life harder than it needs to be. Our conventions for > > formatting commit log messages don't apply to feature branches. On > > feature branches, the developers are free to format the log messages > > as they see fit; the only log message that matters is the one for the > > merge-commit which lands the feature branch on master (which you have > > to create by hand anyway). > > > > The upshot of all this is that while you are working on a feature > > branch: > > > > . you can use short single-line note-like log messages, which might > > be unclear to anyone but yourself > > . you should generally commit each time when you finish some > > meaningful changeset, so that it could be later reverted without > > complications -- this goes well with short log messages > > . it is futile to use "C-x 4 a"-style log messages, especially for > > changes in files or in functions the branch adds, because in the > > final commit log we only need to see "foo: New file" > > Is this written down somewhere? Not that I know of, no. > I had no idea about it. Did you work on feature branches of the Emacs Git repository? Very few people did or do, so having this in the documentation for the benefit of a very few sounds un-economical. I won't object to having this in some place in admin/notes if someone finds that useful, but please note that what I wrote is by no means agreed upon by everyone: opinions vary widely and wildly on what are the best practices of working on branches, starting from the merge vs rebase issue (if one uses rebase, the log messages of intermediate commits disappear anyway). > If I'd recently started a feature branch, I'd likely have been > carefully formatting my commits, for no good reason. Which is why I posted the above. Now you know.