Add new sqlite extensions to allowlist

Add new sqlite extensions to allowlist

[Neo Dim]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

Hi. I would like to use semantic search in one (or maybe couple) of my new packages for emacs. In latest emacs there is sqlite support, which  is great. I would like to use it with https://github.com/asg017/sqlite-vss extension. I checked it out and see that vector0 and vss0 not in allowlist. Can we add this extensions to allowlist? And can we use full path to extension when call `sqlite-load-extension`? I don’t think that this extensions will be system-wide.

Best regards,
Sergey Kostyaev

[-- Attachment #2: Type: text/html, Size: 794 bytes --]

Re: Add new sqlite extensions to allowlist

[Andrew Hyatt]

 
On  6 November 2023 22:13, Neo Dim <sskostyaev@gmail.com> wrote: 

    Hi. I would like to use semantic search in one (or maybe 
    couple) of my new packages for emacs. In latest emacs there is 
    sqlite support, which  is great. I would like to use it with 
    https://github.com/asg017/sqlite-vss extension. I checked it 
    out and see that vector0 and vss0 not in allowlist. Can we add 
    this extensions to allowlist? And can we use full path to 
    extension when call `sqlite-load-extension`? I don’t think 
    that this extensions will be system-wide.

Agreed! I'd also like to use those extensions. In my ekg package 
(https://github.com/ahyatt/ekg), I basically am doing vector 
similarity computations in elisp, from data in a sqlite db, and 
doing everything in elisp undoubtedly slower and more expensive. 
Having a fast way to do this would be very nice.
    
    Best regards,
    Sergey Kostyaev

Re: Add new sqlite extensions to allowlist

[Eli Zaretskii]

> From: Neo Dim <sskostyaev@gmail.com>
> Date: Mon, 6 Nov 2023 22:13:32 +0700
> 
> Hi. I would like to use semantic search in one (or maybe couple) of my new packages for emacs. In
> latest emacs there is sqlite support, which  is great. I would like to use it with
> https://github.com/asg017/sqlite-vss extension. I checked it out and see that vector0 and vss0 not in
> allowlist. Can we add this extensions to allowlist?

I added them, so they will be available in the upcoming Emacs 29.2.

> And can we use full path to extension when call
> `sqlite-load-extension`?

Yes, of course.  The allow-list is checked against the basename of the
library, so the leading directories should not be important.

Re: Add new sqlite extensions to allowlist

[Sergey Kostyaev]

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

Thank you, Eli. I will try it out.

Best regards,
Sergey Kostyaev 

18 ноября 2023 г. 09:13:19 UTC, Eli Zaretskii <eliz@gnu.org> пишет:
>> From: Neo Dim <sskostyaev@gmail.com>
>> Date: Mon, 6 Nov 2023 22:13:32 +0700
>> 
>> Hi. I would like to use semantic search in one (or maybe couple) of my new packages for emacs. In
>> latest emacs there is sqlite support, which  is great. I would like to use it with
>> https://github.com/asg017/sqlite-vss extension. I checked it out and see that vector0 and vss0 not in
>> allowlist. Can we add this extensions to allowlist?
>
>I added them, so they will be available in the upcoming Emacs 29.2.
>
>> And can we use full path to extension when call
>> `sqlite-load-extension`?
>
>Yes, of course.  The allow-list is checked against the basename of the
>library, so the leading directories should not be important.

[-- Attachment #2: Type: text/html, Size: 1590 bytes --]

Re: Add new sqlite extensions to allowlist

[Sergey Kostyaev]

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]

It works, thank you!

Best regards,
Sergey Kostyaev 

18 ноября 2023 г. 09:13:19 UTC, Eli Zaretskii <eliz@gnu.org> пишет:
>> From: Neo Dim <sskostyaev@gmail.com>
>> Date: Mon, 6 Nov 2023 22:13:32 +0700
>> 
>> Hi. I would like to use semantic search in one (or maybe couple) of my new packages for emacs. In
>> latest emacs there is sqlite support, which  is great. I would like to use it with
>> https://github.com/asg017/sqlite-vss extension. I checked it out and see that vector0 and vss0 not in
>> allowlist. Can we add this extensions to allowlist?
>
>I added them, so they will be available in the upcoming Emacs 29.2.
>
>> And can we use full path to extension when call
>> `sqlite-load-extension`?
>
>Yes, of course.  The allow-list is checked against the basename of the
>library, so the leading directories should not be important.

[-- Attachment #2: Type: text/html, Size: 1576 bytes --]

Re: Add new sqlite extensions to allowlist

[Eli Zaretskii]

> Date: Sun, 26 Nov 2023 18:54:36 +0000
> From: Sergey Kostyaev <sskostyaev@gmail.com>
> CC: emacs-devel@gnu.org
> 
> It works, thank you!

Thanks for testing.