From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Cygwin patches Date: Sat, 21 Nov 2009 23:48:41 +0200 Message-ID: <83ws1jo8g6.fsf@gnu.org> References: <4B06F562.8060504@cornell.edu> <871vjs7tn4.fsf@stupidchicken.com> <4B071784.5030901@cornell.edu> <83my2gpa83.fsf@gnu.org> <4B07D914.8070608@cornell.edu> <836394oxr9.fsf@gnu.org> <4B0859F2.8080202@cornell.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1258841463 31521 80.91.229.12 (21 Nov 2009 22:11:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 Nov 2009 22:11:03 +0000 (UTC) Cc: cyd@stupidchicken.com, emacs-devel@gnu.org To: Ken Brown Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 21 23:10:55 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NBy9n-0003SB-Sd for ged-emacs-devel@m.gmane.org; Sat, 21 Nov 2009 23:10:16 +0100 Original-Received: from localhost ([127.0.0.1]:37156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBxqM-0003Br-Rf for ged-emacs-devel@m.gmane.org; Sat, 21 Nov 2009 16:50:10 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NBxqI-0003BM-Bp for emacs-devel@gnu.org; Sat, 21 Nov 2009 16:50:06 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NBxqD-000378-NB for emacs-devel@gnu.org; Sat, 21 Nov 2009 16:50:05 -0500 Original-Received: from [199.232.76.173] (port=55600 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBxqD-000375-Hb for emacs-devel@gnu.org; Sat, 21 Nov 2009 16:50:01 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:35651) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NBxqD-0008AM-0K for emacs-devel@gnu.org; Sat, 21 Nov 2009 16:50:01 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0KTH00I00B5GH200@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Sat, 21 Nov 2009 23:48:56 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.70.37.193]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KTH00DCYB94NCB0@a-mtaout23.012.net.il>; Sat, 21 Nov 2009 23:48:41 +0200 (IST) In-reply-to: <4B0859F2.8080202@cornell.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:117455 Archived-At: > Date: Sat, 21 Nov 2009 16:21:54 -0500 > From: Ken Brown > CC: cyd@stupidchicken.com, emacs-devel@gnu.org > > When I try to test this in emacs 23.1, I get an error > > if: Wrong number of arguments: called-interactively-p, 1 > > The following additional patch, restoring something from the emacs 23.1 > version of browse-url, fixes it: > > @@ -770,7 +774,7 @@ > Prompts for a URL, defaulting to the URL at or before point. Variable > `browse-url-browser-function' says which browser to use." > (interactive (browse-url-interactive-arg "URL: ")) > - (unless (called-interactively-p 'interactive) > + (unless (interactive-p) Didn't we have a change in called-interactively-p on the trunk wrt Emacs 23.1?