From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: make dist target for Windows Date: Sun, 04 Apr 2010 10:10:07 +0300 Message-ID: <83wrwnzoa8.fsf@gnu.org> References: <4BB2BB70.3090608@gmail.com> <83eij0zydg.fsf@gnu.org> <4BB3FB7C.3040106@gmail.com> <83iq8by6bw.fsf@gnu.org> <4BB571EA.4030209@gmail.com> <83k4sqw9av.fsf@gnu.org> <4BB77B64.3080501@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1270365069 6294 80.91.229.12 (4 Apr 2010 07:11:09 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 4 Apr 2010 07:11:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Christoph Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 04 09:11:05 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NyJz6-0000tN-OJ for ged-emacs-devel@m.gmane.org; Sun, 04 Apr 2010 09:11:05 +0200 Original-Received: from localhost ([127.0.0.1]:55120 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NyJz6-0003PQ-0V for ged-emacs-devel@m.gmane.org; Sun, 04 Apr 2010 03:11:04 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NyJz0-0003Nl-5P for emacs-devel@gnu.org; Sun, 04 Apr 2010 03:10:58 -0400 Original-Received: from [140.186.70.92] (port=40384 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NyJyy-0003LP-MA for emacs-devel@gnu.org; Sun, 04 Apr 2010 03:10:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NyJyt-0007Gk-FL for emacs-devel@gnu.org; Sun, 04 Apr 2010 03:10:56 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:54135) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NyJys-0007GP-R3 for emacs-devel@gnu.org; Sun, 04 Apr 2010 03:10:51 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0L0C00B00BP3JE00@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Sun, 04 Apr 2010 10:10:07 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.124.92.42]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L0C00A54BWRBX40@a-mtaout23.012.net.il>; Sun, 04 Apr 2010 10:10:07 +0300 (IDT) In-reply-to: <4BB77B64.3080501@gmail.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:123153 Archived-At: > Date: Sat, 03 Apr 2010 11:31:16 -0600 > From: Christoph > CC: emacs-devel@gnu.org > > Find v4 of the patch attached. > > Major changes: > - configure.bat takes multiple --distfiles arguments for packaging more > than one library in the binary distribution > - configure.bat verifies that all specified distfiles exist and warns if > they don't > - updated INSTALL documentation Thanks. A couple of nits: > +set distFilesOK=1 > +echo ...all distfiles found. > +goto :distFilesDone > + > +:distFilesNotFound > +set distFilesOk=0 > +echo ...%fileNotFound% not found. > +set distfiles= > +goto :distfilesDone You set distFilesOk here, but you never unset it before exiting the script. In general, type "set RET" after running the script, and pay attention to any variables from the script in the environment -- they need to be unset before you exit the script. > +dist: install-bin > + $(CP) $(DIST_FILES) $(INSTALL_DIR)/bin > + $(CP) README.W32 $(INSTALL_DIR) > + zipdist.bat $(INSTALL_DIR) $(VERSION) Hmm... did you try running "make dist" with some sh.exe on your PATH? I think it's not a good idea to rely on a Unixy shell to know how to run Windows batch files. I would suggest to invoke through the Windows shell explicitly: $(COMSPEC) /c $(ARGQUOTE)zipdist.bat $(DQUOTE)$(INSTALL_DIR)$(DQUOTE) $(VERSION)$(ARGQUOTE) The $(*QUOTE) stuff is needed in case $(INSTALL_DIR) includes spaces, but please test that this works, both with cmd.exe and sh.exe as the shell, because I didn't. > BTW, Eli, thanks for taking the time to review this with such attention > to detail. I appreciate it. Thank _you_ for working on this in the first place.