Menu bar broken on MS-DOS

Menu bar broken on MS-DOS

[Eli Zaretskii]

The MS-DOS build comes up without a menu bar in the initial frame (and
in every frame created thereafter), although the value of
menu-bar-mode is t.  Toggling menu-bar-mode twice restores the menu
bar.

I think this is due to the changes in revno 100650:

    2010-06-27  Chong Yidong  <cyd@stupidchicken.com>

	    * startup.el (command-line): Use X resources to set the value of
	    menu-bar-mode and tool-bar-mode, before calling frame-initialize.

	    * menu-bar.el (menu-bar-mode):
	    * tool-bar.el (tool-bar-mode): Don't change default-frame-alist.
	    Set init-value to t.

	    * frame.el (frame-notice-user-settings): Don't change
	    default-frame-alist based on menu-bar-mode and tool-bar-mode, or
	    vice versa (Bug#2249).

Before that change, startup.el called `(menu-bar-mode 1)', but now it
doesn't.  I cannot see where this call is made now.  Can you please
describe how does this work on X?  I will then see how to make the DOS
build work similarly to X and w32.

Re: Menu bar broken on MS-DOS

[Chong Yidong]

Eli Zaretskii <eliz@gnu.org> writes:

> Before that change, startup.el called `(menu-bar-mode 1)', but now it
> doesn't.  I cannot see where this call is made now.  Can you please
> describe how does this work on X?  I will then see how to make the DOS
> build work similarly to X and w32.

The variable menu-bar-mode defaults to t.  In x-create-frame, there are
the following lines:

  x_default_parameter (f, parms, Qmenu_bar_lines,
                       NILP (Vmenu_bar_mode)
                       ? make_number (0) : make_number (1),
                       NULL, NULL, RES_TYPE_NUMBER);

This says that if menu-bar-lines is not supplied as a parameter to
make-frame (or in default-frame-alist), the value of the menu-bar-lines
frame parameter defaults to 0 if menu-bar-mode is nil, and 1 otherwise.

Re: Menu bar broken on MS-DOS

[Eli Zaretskii]

> From: Chong Yidong <cyd@stupidchicken.com>
> Cc: emacs-devel@gnu.org
> Date: Fri, 02 Jul 2010 14:26:28 -0400
> 
>   x_default_parameter (f, parms, Qmenu_bar_lines,
>                        NILP (Vmenu_bar_mode)
>                        ? make_number (0) : make_number (1),
>                        NULL, NULL, RES_TYPE_NUMBER);
> 
> This says that if menu-bar-lines is not supplied as a parameter to
> make-frame (or in default-frame-alist), the value of the menu-bar-lines
> frame parameter defaults to 0 if menu-bar-mode is nil, and 1 otherwise.

Thanks.  I did something similar in msdos.c.

Btw, the --without-x build on GNU/Linux also starts up without showing
the (dysfunctional) menu bar.  Is that change intentional?