From: Eli Zaretskii <eliz@gnu.org>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: EMACS_INT cleanup
Date: Thu, 23 Sep 2010 22:46:09 +0200 [thread overview]
Message-ID: <83wrqctcha.fsf@gnu.org> (raw)
In-Reply-To: <m34odgnqeu.fsf@quimbies.gnus.org>
> From: Lars Magne Ingebrigtsen <larsi@gnus.org>
> Date: Thu, 23 Sep 2010 22:41:45 +0200
>
> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>
> > I just added the (int) here, which seemed to do the trick:
> >
> > #define USE_SAFE_ALLOCA \
> > int sa_count = (int) SPECPDL_INDEX (), sa_must_free = 0
>
> Or perhaps this would be better:
>
> #define SPECPDL_INDEX() ((int) (specpdl_ptr - specpdl))
>
> It'd get rid of a lot of warnings, and we're really returning an int,
> aren't we? Sort of?
Better make it a type that is 64-bit wide on a 64-bit host. Perhaps
#define SPECPDL_INDEX() ((unsigned long) (specpdl_ptr - specpdl))
Although I doubt that someone will have more than 2GB or
unwind_protect'ed methods, but it's probably cleaner that way, because
it doesn't require one reason about the possible magnitude of the
values.
next prev parent reply other threads:[~2010-09-23 20:46 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 18:37 EMACS_INT cleanup Lars Magne Ingebrigtsen
2010-09-23 19:00 ` Eli Zaretskii
2010-09-23 19:02 ` Lars Magne Ingebrigtsen
2010-09-23 19:29 ` Lars Magne Ingebrigtsen
2010-09-23 19:34 ` Lars Magne Ingebrigtsen
2010-09-23 19:53 ` Eli Zaretskii
2010-09-23 20:05 ` Lars Magne Ingebrigtsen
2010-09-23 20:27 ` Eli Zaretskii
2010-09-23 20:29 ` Lars Magne Ingebrigtsen
2010-09-23 20:40 ` Eli Zaretskii
2010-09-23 20:52 ` Lars Magne Ingebrigtsen
2010-09-23 20:41 ` Lars Magne Ingebrigtsen
2010-09-23 20:46 ` Eli Zaretskii [this message]
2010-09-23 20:52 ` Eli Zaretskii
2010-09-23 20:53 ` Lars Magne Ingebrigtsen
2010-09-23 22:07 ` Lars Magne Ingebrigtsen
2010-09-23 22:12 ` Juanma Barranquero
2010-09-23 22:46 ` Lars Magne Ingebrigtsen
2010-09-24 0:01 ` Stefan Monnier
2010-09-24 7:47 ` Eli Zaretskii
2010-09-24 9:43 ` Miles Bader
2010-09-24 10:05 ` Eli Zaretskii
2010-09-24 10:32 ` Eli Zaretskii
2010-09-24 11:02 ` Lars Magne Ingebrigtsen
2010-09-24 11:58 ` Eli Zaretskii
2010-09-24 13:00 ` Lars Magne Ingebrigtsen
2010-09-24 13:09 ` Eli Zaretskii
2010-09-24 13:23 ` Lars Magne Ingebrigtsen
2010-09-24 13:35 ` Eli Zaretskii
2010-09-24 13:40 ` Lars Magne Ingebrigtsen
2010-09-24 13:51 ` Lars Magne Ingebrigtsen
2010-09-24 14:04 ` David Kastrup
2010-09-23 22:30 ` Stefan Monnier
2010-09-23 22:53 ` Lars Magne Ingebrigtsen
2010-09-23 23:59 ` Stefan Monnier
2010-09-24 0:07 ` Lars Magne Ingebrigtsen
2010-09-24 9:04 ` Andreas Schwab
2010-09-24 7:54 ` Eli Zaretskii
2010-09-24 7:51 ` Eli Zaretskii
2010-09-23 20:21 ` David Kastrup
2010-09-23 20:24 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wrqctcha.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).