From: Eli Zaretskii <eliz@gnu.org>
To: larsi@gnus.org, emacs-devel@gnu.org
Subject: Re: Redirecting standard output
Date: Sat, 07 May 2011 15:10:03 +0300 [thread overview]
Message-ID: <83wri2k8ys.fsf@gnu.org> (raw)
In-Reply-To: <83zkmykamq.fsf@gnu.org>
> Date: Sat, 07 May 2011 14:34:05 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
>
> I fixed that; see the diffs for revno 104152.1.2 for the gory details
> (if you are interested).
Btw, while working on this, I noticed that the code fragment shown
below is doing a lot of work that is just thrown away in the case that
`:file' is used to redirect stdout of the child. That's because we
will never read from that file, so setting up the coding-system to
decode it seems futile.
Should we do all that only when output_to_buffer is non-zero?
if (NILP (buffer))
{
/* If BUFFER is nil, we must read process output once and then
discard it, so setup coding system but with nil. */
setup_coding_system (Qnil, &process_coding);
}
else
{
Lisp_Object val, *args2;
val = Qnil;
if (!NILP (Vcoding_system_for_read))
val = Vcoding_system_for_read;
else
{
if (EQ (coding_systems, Qt))
{
size_t i;
SAFE_ALLOCA (args2, Lisp_Object *, (nargs + 1) * sizeof *args2);
args2[0] = Qcall_process;
for (i = 0; i < nargs; i++) args2[i + 1] = args[i];
coding_systems
= Ffind_operation_coding_system (nargs + 1, args2);
}
if (CONSP (coding_systems))
val = XCAR (coding_systems);
else if (CONSP (Vdefault_process_coding_system))
val = XCAR (Vdefault_process_coding_system);
else
val = Qnil;
}
Fcheck_coding_system (val);
/* In unibyte mode, character code conversion should not take
place but EOL conversion should. So, setup raw-text or one
of the subsidiary according to the information just setup. */
if (NILP (BVAR (current_buffer, enable_multibyte_characters))
&& !NILP (val))
val = raw_text_coding_system (val);
setup_coding_system (val, &process_coding);
}
immediate_quit = 1;
QUIT;
next prev parent reply other threads:[~2011-05-07 12:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 21:19 Redirecting standard output Lars Magne Ingebrigtsen
2011-04-20 22:54 ` Stefan Monnier
2011-04-21 1:54 ` Lars Magne Ingebrigtsen
2011-04-21 6:10 ` Eli Zaretskii
2011-04-21 11:45 ` Lars Magne Ingebrigtsen
2011-04-21 13:25 ` Lars Magne Ingebrigtsen
2011-04-21 14:10 ` Eli Zaretskii
2011-04-21 15:15 ` Lars Magne Ingebrigtsen
2011-04-21 15:46 ` Lars Magne Ingebrigtsen
2011-04-21 16:15 ` Eli Zaretskii
2011-04-21 16:22 ` Lars Magne Ingebrigtsen
2011-04-21 16:24 ` Lars Magne Ingebrigtsen
2011-04-21 16:55 ` Eli Zaretskii
2011-04-21 17:05 ` Jan Djärv
2011-04-21 19:15 ` Eli Zaretskii
2011-04-21 19:19 ` Davis Herring
2011-04-21 19:31 ` Lars Magne Ingebrigtsen
2011-04-22 5:50 ` Eli Zaretskii
2011-04-23 18:46 ` Lars Magne Ingebrigtsen
2011-04-23 20:10 ` Eli Zaretskii
2011-04-24 8:30 ` Jan Djärv
2011-04-30 23:58 ` Lars Magne Ingebrigtsen
2011-05-01 0:06 ` Lars Magne Ingebrigtsen
2011-05-01 17:56 ` Andy Moreton
2011-05-07 11:34 ` Eli Zaretskii
2011-05-07 12:10 ` Eli Zaretskii [this message]
2011-05-30 17:39 ` Lars Magne Ingebrigtsen
2011-04-21 16:29 ` Glenn Morris
2011-04-21 8:27 ` Michael Albinus
2011-04-21 5:57 ` Eli Zaretskii
2011-04-21 6:28 ` Thierry Volpiatto
2011-04-21 6:41 ` Eli Zaretskii
2011-04-21 7:33 ` Thierry Volpiatto
2011-04-21 11:40 ` Lars Magne Ingebrigtsen
2011-04-21 11:58 ` Eli Zaretskii
2011-04-21 12:24 ` Lars Magne Ingebrigtsen
2011-04-21 14:25 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wri2k8ys.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).