From: Eli Zaretskii <eliz@gnu.org>
To: Christoph Scholtes <cschol2112@googlemail.com>
Cc: emacs-devel@gnu.org
Subject: Re: addpm.exe missing from installation
Date: Sun, 10 Jun 2012 19:03:03 +0300 [thread overview]
Message-ID: <83wr3frw7c.fsf@gnu.org> (raw)
In-Reply-To: <4FD4B1A2.5000502@gmail.com>
> Date: Sun, 10 Jun 2012 08:39:30 -0600
> From: Christoph Scholtes <cschol2112@googlemail.com>
>
> Hi Eli,
>
> When building and checking the binary distribution for Emacs 24.1 I
> noticed that addpm.exe was missing from the bin directory.
>
> This was introduced in the following change (and has slipped through the
> cracks in subsequent pretest builds since 24.0.95):
>
> revno: 107676
> committer: Eli Zaretskii <eliz@gnu.org>
> branch nick: trunk
> timestamp: Sun 2012-03-25 20:17:46 +0200
> message:
> Fix parallel "make install" on MS-Windows.
>
> nt/makefile.w32-in (install-bin): Don't copy addpm.exe here.
>
> [snip]
>
>
> The install-bin target should install all binary files in the bin folder
> (incl. addpm.exe), while install-shortcuts should just _invoke_
> addpm.exe to install the shortcuts.
Sorry, I don't follow: aren't you invoking "make install"? If not,
what Make command are you using that doesn't work?
The change I made moved addpm.exe installation from install-bin to
install-shortcuts, both of which are run by "make install". The full
log entry reads:
* makefile.w32-in (install-bin): Don't copy addpm.exe here. Use
$(DIRNAME)_same-dir.tst instead of same-dir.tst, to avoid stepping
on other (parallel) Make job's toes.
(install-other-dirs-nmake, install-other-dirs-gmake): Depend on `all'.
(install-shortcuts): Depend on $(INSTALL_DIR)/bin. Copy addpm.exe
here.
(maybe-copy-distfiles-CMD, maybe-copy-distfiles-SH, dist): Depend
on create-tmp-dist-dir.
So copying of addpm.exe wasn't just removed, it was moved. Granted, I
tested the change, and it worked for me.
In general, addpm.exe is not needed, unless one wants to create or
update the shortcuts, which is why I didn't hesitate to move that
command (in its previous place, it interfered with parallel execution
of "make install", which was the motivation for the change).
next prev parent reply other threads:[~2012-06-10 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-10 14:39 addpm.exe missing from installation Christoph Scholtes
2012-06-10 16:03 ` Eli Zaretskii [this message]
2012-06-10 18:11 ` Christoph Scholtes
2012-06-10 20:05 ` Eli Zaretskii
2012-06-10 20:38 ` Christoph Scholtes
2012-06-16 13:18 ` Eli Zaretskii
2012-06-19 3:27 ` Christoph Scholtes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wr3frw7c.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=cschol2112@googlemail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).