Re: [Emacs-diffs] xwidget updated (1d8b8a2 -> 5f46725)

[Eli Zaretskii <eliz@gnu.org>]

> From: joakim@verona.se
> Cc: monnier@iro.umontreal.ca,  emacs-devel@gnu.org
> Date: Fri, 09 Jan 2015 21:12:39 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >
> >> > 5) xdisp.c:produce_xwidget_glyph needs to account for bidirectional
> >> >    display in the same way produce_image_glyph does: swao the left and
> >> >    right box edges, and populate the bidi members of struct glyph.
> >
> >> I havent thought about bidi at all.
> >
> > Just look at what produce_image_glyph does, it should tell you enough.
> >
> >> Do you have a simple test case [for bidi]?
> >
> > Type a few Arabic or Hebrew characters, then insert a widget, then
> > type some more Arabic or Hebrew.  Try this both in a buffer that has
> > bidi-paragraph-direction set to nil and in a buffer that has it set to
> > left-to-right or right-to-left.
> 
> I tried this briefly by opening the hello file and pasting an arabic
> hello string a couple of times.
> 
> Stuff happens, but maybe not the correct stuff. It is hard for me to tell.

Describe the "stuff that happens", or show a snapshot, and perhaps I
will be able to tell if its correct.